From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 13B651F54E for ; Sun, 10 Jul 2022 16:39:26 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="s/hfOqv6"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229663AbiGJQjY (ORCPT ); Sun, 10 Jul 2022 12:39:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229463AbiGJQjY (ORCPT ); Sun, 10 Jul 2022 12:39:24 -0400 Received: from pb-smtp20.pobox.com (pb-smtp20.pobox.com [173.228.157.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F37110FDE for ; Sun, 10 Jul 2022 09:39:23 -0700 (PDT) Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id E0DC919D4C6; Sun, 10 Jul 2022 12:39:22 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=1t/B+w/ouUU1 yad5rpM7QZ/HOC+KuWQ8OuXbOj+0xrc=; b=s/hfOqv67qMncICZlYWnozE2/RVi llHCz3aMOLx5MaRH222Mx1D1DHcKsHm/i0qyvv0fq0DJ7djJ+2E35DUysPi58H8Y QU6RIz6cU72SbbpWOWXxajk0hXBZqMBpSwIxRsf5pISclcrA6fMXTC8XSOgFtnGe 8EKLlsPHVVz9BF4= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id D9FED19D4C5; Sun, 10 Jul 2022 12:39:22 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.92.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 8CB0519D4C4; Sun, 10 Jul 2022 12:39:19 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: "brian m. carlson" , git@vger.kernel.org, Ramsay Jones , Jeff King Subject: Re: [PATCH v2] sha256: add support for Nettle References: <20220705230518.713218-1-sandals@crustytoothpaste.net> <20220710132907.1499365-1-sandals@crustytoothpaste.net> <220710.86mtdh81ty.gmgdl@evledraar.gmail.com> Date: Sun, 10 Jul 2022 09:39:18 -0700 In-Reply-To: <220710.86mtdh81ty.gmgdl@evledraar.gmail.com> (=?utf-8?B?IsOG?= =?utf-8?B?dmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Sun, 10 Jul 2022 16:41:23 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: D86F6428-006E-11ED-AD6B-C85A9F429DF0-77302942!pb-smtp20.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > This just carries forward existing technical debt, but it's unfortunate > that we don't catch OPENSSL_SHA256 overridding NETTLE_SHA256, and error > if both are defined. You are mistaken, unless I am ;-) =20 Allowing users to list whatever is available, instead of requiring all users to choose only one, is a deliberate feature in the arrangement, so it is not unfortunate and it would be breaking end-user expectation if we gave an error when more than one is given (and it would be easier to write and maintain autoconf rules for the feature---we do not want to have two places that makes decisions on precedence).