From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] promisor-remote: fix xcalloc() argument order
Date: Wed, 24 Aug 2022 08:58:21 -0700 [thread overview]
Message-ID: <xmqqwnax8wgy.fsf@gitster.g> (raw)
In-Reply-To: <20220823095733.58685-1-szeder.dev@gmail.com> ("SZEDER Gábor"'s message of "Tue, 23 Aug 2022 11:57:33 +0200")
SZEDER Gábor <szeder.dev@gmail.com> writes:
> Patch generated with:
>
> make SPATCH_FLAGS=--recursive-includes contrib/coccinelle/xcalloc.cocci.patch
>
> Our default SPATCH_FLAGS ('--all-includes') doesn't catch this
> transformation by default, unless used in combination with a large-ish
> SPATCH_BATCH_SIZE which happens to put 'promisor-remote.c' with a file
> that includes 'repository.h' directly in the same batch.
Our default SPATCH_FLAGS is actually
SPATCH_FLAGS = --all-includes --patch .
and I am wondering how "--patch ." part (or droppage thereof due to
overriding it from the command line) affects the outcome.
In any case, good finding how the header file inclusion was affected
with batch-size and this option that solved a mystery. Thanks.
next prev parent reply other threads:[~2022-08-24 15:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 21:34 [PATCH] promisor-remote: fix xcalloc() argument order SZEDER Gábor
2022-08-22 22:14 ` Junio C Hamano
2022-08-23 1:09 ` Junio C Hamano
2022-08-23 7:04 ` SZEDER Gábor
2022-08-23 9:21 ` SZEDER Gábor
2022-08-23 9:56 ` SZEDER Gábor
2022-08-23 9:57 ` [PATCH v2] " SZEDER Gábor
2022-08-24 8:32 ` Jeff King
2022-08-24 11:39 ` SZEDER Gábor
2022-08-25 10:40 ` Jeff King
2022-08-25 13:51 ` Ævar Arnfjörð Bjarmason
2022-08-24 15:58 ` Junio C Hamano [this message]
2022-08-24 17:33 ` SZEDER Gábor
2022-08-24 21:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwnax8wgy.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).