From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 5460A1F506 for ; Mon, 19 Sep 2022 21:43:12 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="NUcW0GmW"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229681AbiISVnI (ORCPT ); Mon, 19 Sep 2022 17:43:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229592AbiISVnG (ORCPT ); Mon, 19 Sep 2022 17:43:06 -0400 Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 383122F646 for ; Mon, 19 Sep 2022 14:43:06 -0700 (PDT) Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 6A91915048E; Mon, 19 Sep 2022 17:43:05 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; s=sasl; bh=r2ds5PnfXt1FZkd8wmWsDU22y2QFGB42E00yccES/1A=; b=NUcW 0GmWbhn0w/B2u5JT7tBGsVS66UBmg1yq3NRZ3eDnAp/lV2cDlHPmej3tfsnAUja8 dFKBRXrr6DJVfk+c/8Dk69S8RpemZEkmQEkwc34kFmqo7Cq5U7voDtAoBqyYBdDj IVBfzX/b36rUosruEfmg4SbuZZeokxGZgMEwUUU= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 5C67F15048C; Mon, 19 Sep 2022 17:43:05 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.5.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 7FD9015048A; Mon, 19 Sep 2022 17:43:04 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Han-Wen Nienhuys Cc: Han-Wen Nienhuys via GitGitGadget , git@vger.kernel.org, Han-Wen Nienhuys Subject: Re: [PATCH] refs: unify parse_worktree_ref() and ref_type() References: Date: Mon, 19 Sep 2022 14:43:03 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 0AAEE31E-3864-11ED-9622-2AEEC5D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Han-Wen Nienhuys writes: > On Tue, Sep 13, 2022 at 5:43 PM Junio C Hamano wrote: >> then a better approach would be to have a small helper >> parse_local_worktree_ref() and make the primary one into something >> like >>... > > Thanks, good idea. I'm sending you a v2. Hmph, is that "v2" or is there another version of it?