From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 7EB101F51E for ; Thu, 29 Sep 2022 01:51:05 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="xUUNVJ0Z"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234677AbiI2Bui (ORCPT ); Wed, 28 Sep 2022 21:50:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234558AbiI2BuM (ORCPT ); Wed, 28 Sep 2022 21:50:12 -0400 Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80CCBB7C5 for ; Wed, 28 Sep 2022 18:49:37 -0700 (PDT) Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 823D81A9ECE; Wed, 28 Sep 2022 21:49:35 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=Y3fLQVLvI4JPIaUevh2givfJd14Zp89y610gqG 8weSo=; b=xUUNVJ0Z6CH/r4t031PU+Ltx+iIzMskWscbKJFK4Ue08a0SIPSLBTi Svm8aw83/y9XRT3O2A9nSZ4v+1ybfopdDBiuvpkfT3WK+t0Cor0Gvj9WmddgjGhX dgbnHWv2nBqfGq/DL2rkSZASkux82IT9fgRwCJ1NRDk0Wtbb5uUBM= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 7AD191A9ECD; Wed, 28 Sep 2022 21:49:35 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.5.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 335C21A9ECB; Wed, 28 Sep 2022 21:49:32 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Elijah Newren Cc: Johannes Schindelin via GitGitGadget , Git Mailing List , Taylor Blau , Johannes Schindelin Subject: Re: [PATCH v5 2/2] merge-ort: return early when failing to write a blob References: Date: Wed, 28 Sep 2022 18:49:31 -0700 In-Reply-To: (Elijah Newren's message of "Wed, 28 Sep 2022 18:36:33 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: F68B7A28-3F98-11ED-B7C6-B31D44D1D7AA-77302942!pb-smtp21.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Elijah Newren writes: >> To me the description of the issue looks reasonable to me. Any >> comments, Elijah? > > Looks good to me! Excellent. Thanks, both.