From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Jiang Xin <worldhello.net@gmail.com>,
Taylor Blau <me@ttaylorr.com>, Git List <git@vger.kernel.org>,
Kyle Zhao <kylezhao@tencent.com>,
Jiang Xin <zhiyou.jx@alibaba-inc.com>
Subject: Re: [PATCH] t5516: fail to run in verbose mode
Date: Wed, 23 Nov 2022 10:17:29 +0900 [thread overview]
Message-ID: <xmqqwn7mo4eu.fsf@gitster.g> (raw)
In-Reply-To: <Y30eK/mNYeLNtOi2@coredump.intra.peff.net> (Jeff King's message of "Tue, 22 Nov 2022 14:08:27 -0500")
Jeff King <peff@peff.net> writes:
> I agree this is a good fix for now, but I wonder philosophically what it
> means. That is, I could see two arguments:
>
> 1. Our tests sometimes run with stderr connected to a tty and
> sometimes not. This means the test environment isn't consistent,
> and perhaps we should be piping all "-v" tests through "cat" or
> something so that the environment is stable.
Yes, this is tempting (and I almost brought it up in my response),
and a pipe to "|cat" may be hopefully closer than tester's tty to
the redirection to "/dev/null". I didn't know how much closer,
though, and the differences may still matter (we could teach "git
grep" or "git diff --exit-code" to notice that the output is sent to
/dev/null and stop at the first hit, for example), but still "|cat"
is closer than ">/dev/tty".
> None of which needs to hold up this patch, but I wonder if we'd want to
> pursue the larger fix in (1).
Yeah, I agree.
Thanks.
next prev parent reply other threads:[~2022-11-23 1:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 13:40 [PATCH] t5516: fail to run in verbose mode Jiang Xin
2022-11-22 2:22 ` [Internet][PATCH] " kylezhao(赵柯宇)
2022-11-22 4:19 ` [PATCH] " Junio C Hamano
2022-11-22 19:08 ` Jeff King
2022-11-23 1:17 ` Junio C Hamano [this message]
2022-11-24 1:16 ` Jeff King
2022-11-25 4:58 ` Junio C Hamano
2022-11-28 5:13 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqwn7mo4eu.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kylezhao@tencent.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=worldhello.net@gmail.com \
--cc=zhiyou.jx@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).