From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS54825 139.178.88.0/22 X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org [139.178.88.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 233C81F44D for ; Tue, 23 Apr 2024 23:27:28 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.a=rsa-sha256 header.s=sasl header.b=xu+1Rt5u; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B9395284351 for ; Tue, 23 Apr 2024 23:27:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5C81543AB0; Tue, 23 Apr 2024 23:27:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="xu+1Rt5u" Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3C272E62F for ; Tue, 23 Apr 2024 23:27:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=173.228.157.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713914839; cv=none; b=CHGB941pELNhAEcvnaeO+w8l3WAmmZJw6jkYNfXiidFgRLoCjMI3msl0eGn3ZXdTat+QQfS8wLKHxtBG6rv730rHocGKXpZSybe+b1JI/eXwji/Tu+HFV8WTxSyio7Io1LMdmy1tdWL+CamlP3lFXr5DEApN5/RG6gcMqUFuYac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713914839; c=relaxed/simple; bh=FGzNixum0Ym+A45woA+sXaDGBLTis+gw+t7DT8wSDBA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=HE2d3itPVeaYC3ViQKWkG8DhNiKnrxJVrA4Hybw2jEB1tGK2G/mXzpHgOh1FlktcR5tpDyN82Ujf/gT+CZ19K9r4AZWjU1wJOirUuInXiM4JMQWMmcXhhKZIyDUmFVvNL0GCGi1KmyZKI133ZJOZL+on8P9OSv7OINis1vyPGAw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b=xu+1Rt5u; arc=none smtp.client-ip=173.228.157.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 740EB2EAF3; Tue, 23 Apr 2024 19:27:17 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=FGzNixum0Ym+A45woA+sXaDGBLTis+gw+t7DT8 wSDBA=; b=xu+1Rt5uBZYMZOhRabCkNfqPru8JAvcneNvx5pxGN3K40oi+ah7LbH H+rM81NqHEJ01s+X9W9bcyd4PHOv0O0V2Pn/Uqyu2HNg3vi17L3nRgbXJWS/V0V6 Ymg5O0s50hPzD/YXD6VN/Xcs3aRISMFrC5quaMmOlYmwW3APESPOA= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 6C46C2EAF2; Tue, 23 Apr 2024 19:27:17 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.125.120.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id C3A752EAF1; Tue, 23 Apr 2024 19:27:13 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: "Linus Arver via GitGitGadget" Cc: git@vger.kernel.org, Christian Couder , Emily Shaffer , Josh Steadmon , "Randall S. Becker" , Christian Couder , Kristoffer Haugsbakk , Linus Arver Subject: Re: [PATCH v2 8/8] trailer: retire trailer_info_get() from API In-Reply-To: (Linus Arver via GitGitGadget's message of "Fri, 19 Apr 2024 05:22:33 +0000") References: Date: Tue, 23 Apr 2024 16:27:12 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 03F478CE-01C9-11EF-BC45-A19503B9AAD1-77302942!pb-smtp21.pobox.com "Linus Arver via GitGitGadget" writes: > From: Linus Arver > > Make trailer_info_get() "static" to be file-scoped to trailer.c, because > no one outside of trailer.c uses it. Remove its declaration from > . Yay. But the callers still need to know what parse_trailers() gives them, and what they can do with the struct. Other than that, an obvious last step that concludes the series. Nicely structured.