git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Pranit Bauva <pranit.bauva@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH v2] api-parse-options.txt: document OPT_CMDMODE()
Date: Fri, 25 Mar 2016 14:24:43 -0700	[thread overview]
Message-ID: <xmqqvb4a1c9w.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAFZEwPOaqZmE4oUy7PWDNv_Qvz+hPgZH2YO6VKk5XUtGYL-ziQ@mail.gmail.com> (Pranit Bauva's message of "Sat, 26 Mar 2016 00:38:44 +0530")

Pranit Bauva <pranit.bauva@gmail.com> writes:

> I have used bits from your email. I forgot to add "Helped-by: Junio C
> Hamano <gitster@pobox.com>" . Could you squash it in?

It's OK to omit such a credit for a patch this small.  After
understanding the issues, you would have written essentially the
same thing yourself.

Thanks, queued v2 already.

  reply	other threads:[~2016-03-25 21:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-24  9:07 [PATCH] api-parse-options.txt: document OPT_CMDMODE() Pranit Bauva
2016-03-24 16:07 ` Junio C Hamano
2016-03-24 16:55   ` Pranit Bauva
2016-03-24 17:16     ` Junio C Hamano
2016-03-24 18:04       ` Pranit Bauva
2016-03-25 18:58 ` [PATCH v2] " Pranit Bauva
2016-03-25 19:08   ` Pranit Bauva
2016-03-25 21:24     ` Junio C Hamano [this message]
2016-03-25 20:14   ` [PATCH v3] " Pranit Bauva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqvb4a1c9w.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=pranit.bauva@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).