From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Kaartic Sivaraam <kaarticsivaraam91196@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] commit-template: distinguish status information unconditionally
Date: Sat, 01 Jul 2017 10:21:38 -0700 [thread overview]
Message-ID: <xmqqvancnkd9.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <87mv8oe5zc.fsf@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Sat, 01 Jul 2017 13:44:55 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> Just as someone reading this from the sidelines, very nice to have
> someone working this part of the UI, but it would be much easier to
> review if you included before/after examples of changes, e.g. (for this
> hypothetical change):
>
>
> Before we'd say:
>
> # Please enter the commit message for your changes. Lines starting
> # with '#' will be ignored, and an empty message aborts the commit.
> #
> # Date: <date>
> #
> # On branch master
> # Your branch is up-to-date with 'origin/master'.
>
> Now:
>
> # Please enter the commit message for your changes. Lines starting
> # with '#' will be ignored, and an empty message aborts the commit.
> #
> # Date: <date>
> #
> # On branch master
> # Your current branch is up-to-date with 'origin/master'.
>
> And as a word-diff:
>
> [...]
> # Your {+current+} branch is up-to-date with 'origin/master'.
>
> Or something like that, much easier to read something like that than
> read the code and mentally glue together what it's going to change.
I think you gave an example that is different from what was done on
purpose, so that Kaartic can respond with "I see what you mean; what
I did is different from your example but this.", but it seems that
the attempt failed X-<.
I do not think the patch changes the output in a situation where the
above "Before" would be shown. Instead, when the extra "Date: <date>"
(or "Author: <author>") is not shown, the Before picture would look
like:
# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
# On branch master
and the update makes it look like:
# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
#
# On branch master
Hope that helps.
next prev parent reply other threads:[~2017-07-01 17:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-26 17:24 [PATCH/RFC] commit-template: improve readability of commit template Kaartic Sivaraam
2017-06-26 21:59 ` Junio C Hamano
2017-06-27 17:22 ` Kaartic Sivaraam
2017-06-27 17:56 ` Junio C Hamano
2017-06-28 13:04 ` Kaartic Sivaraam
2017-06-28 14:50 ` Kaartic Sivaraam
2017-06-28 13:29 ` [PATCH] " Kaartic Sivaraam
2017-06-28 14:47 ` Kaartic Sivaraam
2017-06-28 16:48 ` Junio C Hamano
2017-06-29 17:01 ` [PATCH 1/2] commit-template: remove outdated notice about explicit paths Kaartic Sivaraam
2017-06-29 17:01 ` [PATCH 2/2] commit-template: add new line before status information Kaartic Sivaraam
2017-06-29 17:51 ` Junio C Hamano
2017-06-29 18:17 ` Junio C Hamano
2017-06-30 3:19 ` Kaartic Sivaraam
2017-06-29 17:56 ` [PATCH 1/2] commit-template: remove outdated notice about explicit paths Junio C Hamano
2017-06-30 3:18 ` Kaartic Sivaraam
2017-06-30 12:12 ` Kaartic Sivaraam
2017-06-30 12:12 ` [PATCH 2/2] commit-template: distinguish status information unconditionally Kaartic Sivaraam
2017-06-30 14:52 ` Junio C Hamano
2017-07-01 1:59 ` Kaartic Sivaraam
2017-07-01 11:44 ` Ævar Arnfjörð Bjarmason
2017-07-01 12:08 ` Kaartic Sivaraam
2017-07-01 17:21 ` Junio C Hamano [this message]
2017-07-09 17:54 ` [PATCH 1/2] commit-template: remove outdated notice about explicit paths Kaartic Sivaraam
2017-07-09 18:54 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvancnkd9.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=kaarticsivaraam91196@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).