mailing list mirror (one of many)
 help / Atom feed
From: Junio C Hamano <>
To: Max Rothman <>
Subject: Re: [PATCH] completion: add missing completions for log, diff, show
Date: Wed, 08 Nov 2017 13:06:50 +0900
Message-ID: <> (raw)
In-Reply-To: <>

Max Rothman <> writes:

> How about this:
> The bash completion script knows some options to "git log" and
> "git show" only in the positive form, (e.g. "--abbrev-commit"), but not
> in their negative form (e.g. "--no-abbrev-commit"). Adds them.

s/Adds them/Add them/; we speak as if we are giving an order to 
the codebase to "become like so" (or to the patch monkey to "make
the code so").

> Also, the bash completion script is missing some other options to
> "git diff", and "git show" (and thus, all other commands that take
> "git diff"'s options). Adds them. Of note, since "--indent-heuristic" is
> no longer experimental, adds that too.

Likewise for the two "adds".

>>> ---
>> Missed sign-off?
> Whoops, there doesn't seem to be a way to add that separately from the
> commit message in the submitGit interface. I'll try adding it, but
> gmail might turn all the tabs into spaces, so if it does, I'll try to
> figure out how to resubmit.

I would imagine that the cleanest way is to "commit --amend" and
have submitGit see that updated/corrected copy.


      reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-11 14:47 No log --no-decorate completion? Max Rothman
2017-10-11 18:09 ` Stefan Beller
2017-10-12 17:41   ` Max Rothman
2017-10-24 15:32     ` Max Rothman
     [not found]     ` <>
2017-10-24 15:32       ` Stefan Beller
2017-11-02 20:25         ` Max Rothman
2017-11-02 21:19           ` Stefan Beller
2017-11-07 20:31             ` Max Rothman
2017-11-07 20:48               ` Stefan Beller
2017-11-07 21:22                 ` [PATCH] completion: add missing completions for log, diff, show Max Rothman
2017-11-08  2:33                   ` Junio C Hamano
2017-11-08  3:30                     ` Max Rothman
2017-11-08  4:06                       ` Junio C Hamano [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:
       or Tor2web:

AGPL code for this site: git clone public-inbox