From: Junio C Hamano <firstname.lastname@example.org> To: Alex Vandiver <email@example.com> Cc: firstname.lastname@example.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>, Ben Peart <email@example.com> Subject: Re: [PATCH 2/2] fsmonitor: Store fsmonitor bitmap before splitting index Date: Fri, 10 Nov 2017 14:11:41 +0900 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> (Alex Vandiver's message of "Thu, 9 Nov 2017 11:58:10 -0800") Alex Vandiver <firstname.lastname@example.org> writes: > ba1b9caca6 resolved the problem of the fsmonitor data being applied to (from SubmittingPatches) If you want to reference a previous commit in the history of a stable branch, use the format "abbreviated sha1 (subject, date)", with the subject enclosed in a pair of double-quotes, like this: Commit f86a374 ("pack-bitmap.c: fix a memleak", 2015-03-30) noticed that ... The "Copy commit summary" command of gitk can be used to obtain this format, or this invocation of "git show": git show -s --date=short --pretty='format:%h ("%s", %ad)' <commit> > the non-base index when reading; however, a similar problem exists > when writing the index. Specifically, writing of the fsmonitor > extension happens only after the work to split the index has been > applied -- as such, the information in the index is only for the > non-"base" index, and thus the extension information contains only > partial data. So... what's the effect of not applying this change? Do we miss paths that are known to the watchman to have been modified and end up not adding them if we do "git add -u"? Or do we miss paths that are known to the watchman to be clean but mistakenly think are dirty, and spend unnecessary cycles? IOW, is this fixing a correctness issue, or a performance one? > When saving, compute the ewah bitmap before the index is split, and > store it in the fsmonitor_dirty field, mirroring the behavior that > occurred during reading. fsmonitor_dirty is kept from being leaked by > being freed when the extension data is written -- which always happens > precisely once, no matter the split index configuration. The observation and the approach stated to fix both sounds sensible. I'll queue this too, awaiting for Ben's review. Thanks.
next prev parent reply other threads:[~2017-11-10 5:11 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-09 19:58 [PATCH 0/2] fsmonitor: Stop reading from PWD, write fsmonitor+split index right Alex Vandiver 2017-11-09 19:58 ` [PATCH 1/2] fsmonitor: Read from getcwd(), not the PWD environment variable Alex Vandiver 2017-11-09 19:58 ` [PATCH 2/2] fsmonitor: Store fsmonitor bitmap before splitting index Alex Vandiver 2017-11-10 5:11 ` Junio C Hamano [this message] 2017-11-13 15:28 ` Ben Peart 2017-12-16 2:02 ` Alex Vandiver 2017-11-10 5:04 ` [PATCH 1/2] fsmonitor: Read from getcwd(), not the PWD environment variable Junio C Hamano 2017-11-10 21:03 ` [PATCH v1] fsmonitor: simplify determining the git worktree under Windows Ben Peart 2017-11-13 1:02 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --cc=Johannes.Schindelin@gmx.de \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 2/2] fsmonitor: Store fsmonitor bitmap before splitting index' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).