From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: lars.schneider@autodesk.com, git@vger.kernel.org, nico@cam.org,
Lars Schneider <larsxschneider@gmail.com>
Subject: Re: [PATCH v1] progress: print progress output for all operations taking longer than 2s
Date: Mon, 04 Dec 2017 13:38:41 -0800 [thread overview]
Message-ID: <xmqqvahmkwbi.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171204213350.GA21552@sigill.intra.peff.net> (Jeff King's message of "Mon, 4 Dec 2017 16:33:50 -0500")
Jeff King <peff@peff.net> writes:
> So the minimal fix is actually:
>
> diff --git a/progress.c b/progress.c
> index 289678d43d..b774cb1cd1 100644
> --- a/progress.c
> +++ b/progress.c
> @@ -229,7 +229,7 @@ static struct progress *start_progress_delay(const char *title, unsigned total,
>
> struct progress *start_delayed_progress(const char *title, unsigned total)
> {
> - return start_progress_delay(title, total, 0, 2);
> + return start_progress_delay(title, total, 100, 2);
> }
That makes a lot more sense to me (at least from a cursory
comparison between the two approaches).
next prev parent reply other threads:[~2017-12-04 21:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 20:36 [PATCH v1] progress: print progress output for all operations taking longer than 2s lars.schneider
2017-12-04 21:33 ` Jeff King
2017-12-04 21:38 ` Junio C Hamano [this message]
2017-12-04 22:02 ` [PATCH 0/2] fix v2.15 progress regression Jeff King
2017-12-04 22:05 ` [PATCH 1/2] progress: set default delay threshold to 100%, not 0% Jeff King
2017-12-04 22:07 ` [PATCH 2/2] progress: drop delay-threshold code Jeff King
2017-12-05 10:37 ` Lars Schneider
2017-12-05 11:10 ` Ævar Arnfjörð Bjarmason
2017-12-05 12:28 ` Lars Schneider
2017-12-04 22:22 ` [PATCH 0/2] fix v2.15 progress regression Junio C Hamano
2017-12-04 21:35 ` [PATCH v1] progress: print progress output for all operations taking longer than 2s Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvahmkwbi.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=lars.schneider@autodesk.com \
--cc=larsxschneider@gmail.com \
--cc=nico@cam.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).