From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 8D75F1FC34 for ; Fri, 8 Dec 2017 20:26:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753055AbdLHU0J (ORCPT ); Fri, 8 Dec 2017 15:26:09 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:60693 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752405AbdLHU0H (ORCPT ); Fri, 8 Dec 2017 15:26:07 -0500 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 3B7D7AC47B; Fri, 8 Dec 2017 15:26:07 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=a2+RBbgx1lj2tTBz0pQmvAvmr54=; b=M7ucn9 61l15teCqmIXzvc56P81xoLE0YblowTfKimDYOmJU5iNLzD0j036ea14flW6M/aX xLNgxju+Nhb93yivrJ6+DBZOoLiLp8b3KqA8bLuZAOurLAvXTWJwLHq26PrVZNUG V8Sqlf9A4QaIoAOx5eJrb0diTnCtV+dXimdgI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=On/xM0COENva5GbZvwol3Fg5l7ppIEIA lu6v+wWBaQQZHw6N3vA9yI7EpCAoYBUcewiDDOQKVwiyeeecIsqnOTBtdZMILyOD Vou1iG1nGHTTmjEJmaaH3zmipPCKYreGmIBtuxhL9SeReLyxbQ3KkTnKkoGnMb6P bwSfNVHaank= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 34BCFAC47A; Fri, 8 Dec 2017 15:26:07 -0500 (EST) Received: from pobox.com (unknown [104.132.0.95]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id A24F1AC477; Fri, 8 Dec 2017 15:26:06 -0500 (EST) From: Junio C Hamano To: Johannes Schindelin Cc: Brandon Williams , git@vger.kernel.org Subject: Re: [WIP 04/15] upload-pack: convert to a builtin References: <20171020171839.4188-1-bmwill@google.com> <20171204235823.63299-1-bmwill@google.com> <20171204235823.63299-5-bmwill@google.com> Date: Fri, 08 Dec 2017 12:26:05 -0800 In-Reply-To: (Johannes Schindelin's message of "Thu, 7 Dec 2017 17:14:46 +0100 (CET)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 04F873FA-DC56-11E7-94F1-8EF31968708C-77302942!pb-smtp1.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Johannes Schindelin writes: > On Wed, 6 Dec 2017, Junio C Hamano wrote: > ... >> I vaguely recalled and feared that we on purpose kept this program >> separate from the rest of the system for a reason, but my mailing >> list search is coming up empty. > > I only recall that we kept it in the bin/ directory (as opposed to > mlibexec/git-core/) to help with fetching via SSH. Yes, that is about where it is installed (i.e. on $PATH), which is a different issue. My vague recollection was about what is (and what is not) included in and linked into the program built, with some reason that is different from but similar to the reason why remote helpers that link to curl and openssl libraries are excluded from the builtin deliberately. I know we exclude remote-helpers from builtin in order to save the start-up overhead for other more important built-in commands by not having to link these heavyweight libs. I suspect there was some valid reason why we didn't make upload-pack a built-in, but am failing to recall what the reason was.