From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: git@vger.kernel.org, Lars Schneider <larsxschneider@gmail.com>
Subject: Re: [PATCH] travis-ci: build Git during the 'script' phase
Date: Mon, 08 Jan 2018 14:07:09 -0800 [thread overview]
Message-ID: <xmqqvagc6m42.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20180108172214.23615-1-szeder.dev@gmail.com> ("SZEDER Gábor"'s message of "Mon, 8 Jan 2018 18:22:14 +0100")
SZEDER Gábor <szeder.dev@gmail.com> writes:
> The reason why Travis CI does it this way and why it's a better
> approach than ours lies in how unsuccessful build jobs are
> categorized. ...
> ...
> This makes it easier, both for humans looking at the Travis CI web
> interface and for automated tools querying the Travis CI API,...
> ...
> A verbose commit message for such a change... but I don't know why we
> started with building Git in the 'before_script' phase.
Thanks for writing it up clearly. TBH, I didn't even realize that
there were meaningful distinctions between the two cases after
seeing that sometimes our tests were failing and sometimes erroring
;-)
> Should go on top of 'sg/travis-check-untracked' in 'next'.
next prev parent reply other threads:[~2018-01-08 22:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 17:22 [PATCH] travis-ci: build Git during the 'script' phase SZEDER Gábor
2018-01-08 22:07 ` Junio C Hamano [this message]
2018-01-08 22:38 ` Lars Schneider
2018-01-12 13:32 ` SZEDER Gábor
2018-01-13 10:32 ` Jeff King
2018-01-13 10:54 ` Jeff King
2018-01-14 10:43 ` SZEDER Gábor
2018-01-14 11:10 ` Jeff King
2018-01-14 10:37 ` SZEDER Gábor
2018-01-14 11:07 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvagc6m42.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).