From: Junio C Hamano <gitster@pobox.com>
To: Todd Zullinger <tmz@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Makefile: remove *.spec from clean target
Date: Sat, 17 Feb 2018 13:27:12 -0800 [thread overview]
Message-ID: <xmqqvaev489b.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180217030623.GT27038@zaya.teonanacatl.net> (Todd Zullinger's message of "Fri, 16 Feb 2018 22:06:24 -0500")
Todd Zullinger <tmz@pobox.com> writes:
> Support for generating an rpm was dropped in ab214331cf ("Makefile: stop
> pretending to support rpmbuild", 2016-04-04). We don't generate any
> *.spec files so there is no need to clean them up.
>
> Signed-off-by: Todd Zullinger <tmz@pobox.com>
> ---
>
> I noticed this minor cruft today. Since we don't generate a
> spec file, this is at best unneeded. At worst we could
> wrongly delete a users spec file if they happened to be
> working on it in their git clone and called make clean.
Makes perfect sense. Thanks.
>
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index c56fdc14ca..d135f8baa1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2734,7 +2734,7 @@ clean: profile-clean coverage-clean
> $(RM) $(TEST_PROGRAMS) $(NO_INSTALL)
> $(RM) -r bin-wrappers $(dep_dirs)
> $(RM) -r po/build/
> - $(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo common-cmds.h $(ETAGS_TARGET) tags cscope*
> + $(RM) *.pyc *.pyo */*.pyc */*.pyo common-cmds.h $(ETAGS_TARGET) tags cscope*
> $(RM) -r $(GIT_TARNAME) .doc-tmp-dir
> $(RM) $(GIT_TARNAME).tar.gz git-core_$(GIT_VERSION)-*.tar.gz
> $(RM) $(htmldocs).tar.gz $(manpages).tar.gz
> --
> 2.16.2
prev parent reply other threads:[~2018-02-17 21:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-17 3:06 [PATCH] Makefile: remove *.spec from clean target Todd Zullinger
2018-02-17 21:27 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvaev489b.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).