From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Leah Neukirchen <leah@vuxu.org>, git@vger.kernel.org
Subject: Re: [RFC PATCH] color: respect the $NO_COLOR convention
Date: Sun, 04 Mar 2018 18:24:18 -0800 [thread overview]
Message-ID: <xmqqvaeb9s4t.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180304223925.GA808005@genre.crustytoothpaste.net> (brian m. carlson's message of "Sun, 4 Mar 2018 22:39:25 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> As a note, turning off color can improve accessibility for some people.
> I have a co-worker who has deuteranomaly and virtually all colored text
> at the terminal poses readability problems. It would be beneficial if
> he could just set NO_COLOR=1 in his environment and have everything just
> work.
>
> For this reason, I'm in favor of taking this patch, assuming it comes
> with tests.
Oh, I agree 100% the world would be a better place if there already
is an established way to turn off all colors, instead of having to
run around and setting tool specific configuration like LS_COLORS
etc. for 42 different tools one uses during one's daily life. I
just am not getting the feeling this no-color.org's effort is the
one. We already have a way specific to our project already (i.e.
configuration variables), so if we adopt NO_COLOR but other people
do not universally support it (and they support something else),
we'd end up having to maintain yet another knob that only a handful
of projects understand forever, and that is where my reluctance
comes from.
prev parent reply other threads:[~2018-03-05 2:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 16:44 [RFC PATCH] color: respect the $NO_COLOR convention Leah Neukirchen
2018-03-01 17:10 ` Junio C Hamano
2018-03-01 17:23 ` Leah Neukirchen
2018-03-01 19:06 ` Junio C Hamano
2018-03-04 22:39 ` brian m. carlson
2018-03-05 2:24 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvaeb9s4t.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=leah@vuxu.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).