From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Clemens Buchacher <drizzd@gmx.net>, git@vger.kernel.org
Subject: Re: [PATCH] checkout files in-place
Date: Mon, 11 Jun 2018 11:02:42 -0700 [thread overview]
Message-ID: <xmqqvaapb3r1.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180611020411.GE38834@genre.crustytoothpaste.net> (brian m. carlson's message of "Mon, 11 Jun 2018 02:04:11 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
>> + file prevent creating new files at the same path. Note that Git will not
>> + update read/write permissions according to umask.
>
> I'm wondering if it's worth a mention that running out of disk space (or
> quota) will cause data to be truncated.
Aside from us not having to worry about emulating the umask, another
reason why we prefer "create, complete the write, and then finally
rename" over "overwrite and let it fail in the middle" is that the
former makes sure we never leave the path in a bad state. It either
has a complete copy of the old contents, or a complete copy of the
new contents, and a third-party process reading from sidelines would
not get a partial copy, regardless of disc-full issue.
next prev parent reply other threads:[~2018-06-11 18:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-10 19:44 [PATCH] checkout files in-place Clemens Buchacher
2018-06-11 2:04 ` brian m. carlson
2018-06-11 17:48 ` Clemens Buchacher
2018-06-11 18:02 ` Junio C Hamano [this message]
2018-06-11 20:22 ` Clemens Buchacher
2018-06-11 17:59 ` Ævar Arnfjörð Bjarmason
2018-06-11 20:35 ` Edward Thomson
2018-06-11 20:57 ` Clemens Buchacher
[not found] ` <CAGHpTBJFwToEwnk4P17AJ+z-55Nzc04OBbTvsbFRrkXJpfXAkQ@mail.gmail.com>
2018-06-12 8:51 ` Edward Thomson
2018-06-13 7:39 ` Orgad Shaneh
2018-06-11 20:39 ` [PATCH v2] " Clemens Buchacher
2018-06-11 21:38 ` Ævar Arnfjörð Bjarmason
2018-06-11 22:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqvaapb3r1.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=drizzd@gmx.net \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).