From: Junio C Hamano <gitster@pobox.com>
To: Shulhan <m.shulhan@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] builtin/remote: quote remote name on error to display empty name
Date: Fri, 14 Sep 2018 09:22:58 -0700 [thread overview]
Message-ID: <xmqqva78cal9.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180914151710.3261463b@xenom-bubu> (Shulhan's message of "Fri, 14 Sep 2018 15:17:10 +0700")
Shulhan <m.shulhan@gmail.com> writes:
> if source is run successfully before I know the patch was correct, as
> the "t/README" said,
>
> Running Tests
> -------------
>
> The easiest way to run tests is to say "make". This runs all
> the tests.
t/README says that it is sufficient to run "make" to perform tests,
but that implicitly assumes that the people who are reading it are
now in the t/ directory.
We probably want to clarify the language there, perhaps like so?
Thanks.
t/README | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/README b/t/README
index 8373a27fea..f95624959f 100644
--- a/t/README
+++ b/t/README
@@ -14,8 +14,8 @@ describes how your test scripts should be organized.
Running Tests
-------------
-The easiest way to run tests is to say "make". This runs all
-the tests.
+The easiest way to run tests is to say "make" in this directory (or
+"make test" from the top-level). This runs all the tests.
*** t0000-basic.sh ***
ok 1 - .git/objects should be empty after git init in an empty repo.
prev parent reply other threads:[~2018-09-14 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 13:18 [PATCH v2] builtin/remote: quote remote name on error to display empty name Shulhan
2018-09-13 21:51 ` Junio C Hamano
2018-09-13 22:01 ` Junio C Hamano
2018-09-14 8:17 ` Shulhan
2018-09-14 16:22 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqva78cal9.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=m.shulhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).