From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: gitgitgadget@gmail.com, Git List <git@vger.kernel.org>,
charlieio@outlook.com
Subject: Re: [PATCH v6 1/1] http: add support selecting http version
Date: Fri, 09 Nov 2018 11:57:14 +0900 [thread overview]
Message-ID: <xmqqva57556d.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAPig+cRpH0k-qams+_1LK9p8hYzBhD-bG3waNLeCSzYWNY41rg@mail.gmail.com> (Eric Sunshine's message of "Thu, 8 Nov 2018 13:02:04 -0500")
Eric Sunshine <sunshine@sunshineco.com> writes:
>> @@ -284,6 +285,9 @@ static void process_curl_messages(void)
>> static int http_options(const char *var, const char *value, void *cb)
>> {
>> + if (!strcmp("http.version",var)) {
>
> Style: space after comma
>
>> + return git_config_string(&curl_http_version, var, value);
>> + }
>> @@ -806,6 +834,16 @@ static CURL *get_curl_handle(void)
>> + if (curl_http_version) {
>> + long opt;
>> + if (!get_curl_http_version_opt(curl_http_version, &opt)) {
>> + /* Set request use http version */
>> + curl_easy_setopt(result, CURLOPT_HTTP_VERSION,opt);
>
> Style: space after comma
>
>> + }
>> + }
Thanks, both. This is almost done, I think.
next prev parent reply other threads:[~2018-11-09 2:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 13:33 [PATCH 0/1] http: add support selecting http version Force.Charlie-I via GitGitGadget
2018-11-07 13:33 ` [PATCH 1/1] " Force Charlie via GitGitGadget
2018-11-08 1:48 ` Junio C Hamano
2018-11-07 13:44 ` [PATCH 0/1] " Daniel Stenberg
2018-11-08 1:18 ` brian m. carlson
2018-11-08 3:35 ` Junio C Hamano
2018-11-08 1:35 ` [PATCH v2 0/3] " Force.Charlie-I via GitGitGadget
2018-11-08 1:35 ` [PATCH v2 1/3] " Force Charlie via GitGitGadget
2018-11-08 1:35 ` [PATCH v2 2/3] support force use http 1.1 Force Charlie via GitGitGadget
2018-11-08 1:35 ` [PATCH v2 3/3] fix curl version to support CURL_HTTP_VERSION_2TLS Force Charlie via GitGitGadget
2018-11-08 4:54 ` [PATCH v3 0/4] http: add support selecting http version Force.Charlie-I via GitGitGadget
2018-11-08 4:54 ` [PATCH v3 1/4] " Force Charlie via GitGitGadget
2018-11-08 4:55 ` [PATCH v3 2/4] support force use http 1.1 Force Charlie via GitGitGadget
2018-11-08 4:55 ` [PATCH v3 3/4] fix curl version to support CURL_HTTP_VERSION_2TLS Force Charlie via GitGitGadget
2018-11-08 4:55 ` [PATCH v3 4/4] http: change http.version value type Force Charlie via GitGitGadget
2018-11-08 6:14 ` [PATCH v4 0/4] http: add support selecting http version Force.Charlie-I via GitGitGadget
2018-11-08 6:14 ` [PATCH v4 1/4] " Force Charlie via GitGitGadget
2018-11-08 6:14 ` [PATCH v4 2/4] support force use http 1.1 Force Charlie via GitGitGadget
2018-11-08 6:14 ` [PATCH v4 3/4] fix curl version to support CURL_HTTP_VERSION_2TLS Force Charlie via GitGitGadget
2018-11-08 6:14 ` [PATCH v4 4/4] http: change http.version value type Force Charlie via GitGitGadget
2018-11-08 6:18 ` [PATCH v5 0/1] http: add support selecting http version Force.Charlie-I via GitGitGadget
2018-11-08 6:18 ` [PATCH v5 1/1] " Force Charlie via GitGitGadget
2018-11-08 7:00 ` [PATCH v6 0/1] " Force.Charlie-I via GitGitGadget
2018-11-08 7:00 ` [PATCH v6 1/1] " Force Charlie via GitGitGadget
2018-11-08 18:02 ` Eric Sunshine
2018-11-09 2:57 ` Junio C Hamano [this message]
2018-11-09 2:56 ` Junio C Hamano
2018-11-08 23:15 ` [PATCH v7 0/1] " Force.Charlie-I via GitGitGadget
2018-11-08 23:15 ` [PATCH v7 1/1] " Force Charlie via GitGitGadget
2018-11-09 3:52 ` Junio C Hamano
2018-11-09 3:44 ` [PATCH v8 0/1] " Force.Charlie-I via GitGitGadget
2018-11-09 3:44 ` [PATCH v8 1/1] " Force Charlie via GitGitGadget
2018-11-08 6:14 ` [PATCH v3 0/4] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqva57556d.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=charlieio@outlook.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).