list mirror (unofficial, one of many)
 help / color / mirror / Atom feed
From: Junio C Hamano <>
To: Stefan Beller <>
Cc:, Sjon Hortensius <>
Subject: Re: 2.20.0 - Undocumented change in submodule update wrt # parallel jobs
Date: Thu, 13 Dec 2018 23:17:20 +0900
Message-ID: <> (raw)
In-Reply-To: <> (Sjon Hortensius's message of "Thu, 13 Dec 2018 10:15:52 +0100")

Sjon Hortensius <> writes:

> When switching to 2.20 our `git submodule update' (which clones
> through ssh) broke because our ssh-server rejected the ~20
> simultaneous connections the git-client makes. This seems to be caused
> by a (possibly unintended) change in
> which removed the default of max_jobs=1
> While this can easily be fixed by configuring submodule.fetchJobs I
> think this change should be documented - or reverted back to it's
> previous default of 1

The commit in question does not look like it _wanted_ to change the
default; rather, it appears to me that it wanted to be bug-to-bug
compatible with the original, and any such change of behaviour is
entirely unintended.

I think the attached may be sufficient to change the default
max_jobs back to 1.

By the way, is there a place where we document that the default
value for fetchjobs, when unconfigured, is 1?  If we are not making
such a concrete promise, then I would think it is OK to update the
default without any fanfare, as long as we have good reasons to do
so.  For this particular one, however, as I already said, I do not
think we wanted to change the default to unlimited or anything like
that, so...

 builtin/submodule--helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 789d00d87d..e8cdf84f1c 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -1552,7 +1552,7 @@ struct submodule_update_clone {
-	NULL, 0, 0, 0, NULL, 0, 0, 0}
+	NULL, 0, 0, 0, NULL, 0, 0, 1}
 static void next_submodule_warn_missing(struct submodule_update_clone *suc,

  parent reply	other threads:[~2018-12-13 14:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-13  9:15 Sjon Hortensius
2018-12-13 14:02 ` Ævar Arnfjörð Bjarmason
2018-12-13 14:17 ` Junio C Hamano [this message]
2018-12-13 18:50   ` Stefan Beller
2018-12-13 19:02     ` [PATCH] submodule update: run at most one fetch job unless otherwise set Stefan Beller
2018-12-13 19:04       ` Eric Sunshine
2018-12-14  2:53       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ \
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
 note: .onion URLs require Tor:

code repositories for the project(s) associated with this inbox:

AGPL code for this site: git clone