git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Luke Diamand <luke@diamand.org>
Cc: git@vger.kernel.org, viniciusalexandre@gmail.com,
	Romain Merland <merlorom@yahoo.fr>,
	SZEDER Gábor <szeder.dev@gmail.com>,
	Vitor Antunes <vitor.hda@gmail.com>,
	amazo@checkvideo.com, aoakley@roku.com
Subject: Re: [PATCH 0/2] git-p4: handle moved files when updating a P4 shelve
Date: Mon, 14 Jan 2019 10:56:13 -0800
Message-ID: <xmqqva2rukz6.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190113135815.11286-1-luke@diamand.org>

Luke Diamand <luke@diamand.org> writes:

> I found this bug recently in git-p4 - updating a shelved changelist where files
> are being moved doesn't work. The destination of any moves needs to be
> added to the list of files passed to P4.

Thanks.

>
> Luke Diamand (2):
>   git-p4: add failing test for shelved CL update involving move
>   git-p4: handle update of moved files when updating a shelve
>
>  git-p4.py                |  1 +
>  t/t9807-git-p4-submit.sh | 53 +++++++++++++++++++++++++++++++++++++---
>  2 files changed, 51 insertions(+), 3 deletions(-)

      parent reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-13 13:58 Luke Diamand
2019-01-13 13:58 ` [PATCH 1/2] git-p4: add failing test for shelved CL update involving move Luke Diamand
2019-01-13 13:58   ` [PATCH 2/2] git-p4: handle update of moved files when updating a shelve Luke Diamand
2019-01-13 21:57   ` [PATCH 1/2] git-p4: add failing test for shelved CL update involving move Eric Sunshine
2019-01-14 19:03     ` Junio C Hamano
2019-01-14 18:56 ` Junio C Hamano [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqva2rukz6.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=amazo@checkvideo.com \
    --cc=aoakley@roku.com \
    --cc=git@vger.kernel.org \
    --cc=luke@diamand.org \
    --cc=merlorom@yahoo.fr \
    --cc=szeder.dev@gmail.com \
    --cc=viniciusalexandre@gmail.com \
    --cc=vitor.hda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

git@vger.kernel.org list mirror (unofficial, one of many)

Archives are clonable:
	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.org/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox