git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Kyle Meyer <kyle@kyleam.com>
Cc: git@vger.kernel.org, debian@onerussian.com
Subject: Re: [PATCH v3 0/3] dir: treat a repository without commits as a repository
Date: Wed, 10 Apr 2019 12:57:01 +0900	[thread overview]
Message-ID: <xmqqv9zm1piq.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190409230737.26809-1-kyle@kyleam.com> (Kyle Meyer's message of "Tue, 9 Apr 2019 19:07:34 -0400")

Kyle Meyer <kyle@kyleam.com> writes:

> The series improves the handling of sub-repositories that don't have a
> commit checked out.  In particular, it addresses the following issues:
> ...
>   * Commit message tweaks.  These include replacing wording like "no
>     commits" with something like "no commit checked out" because,
>     technically, this series also concerns repositories that have
>     commit objects but are on an unborn branch.

Changes from "not have any commits" to "not have a commit checked
out" can also be seen in the code (the next bullet point), which is
a very welcome change.  It shows that the patchset was done with
nice attention to the detail.

>   * Change the "git submodule add" error message to match the wording
>     of the new error message added in add_to_index().
>
>   * Consistently use "expect" rather than "expected" as the output
>     file name for expected test output.

Thanks; will replace.  Hopefully this round is ready for 'next'.


      parent reply	other threads:[~2019-04-10  3:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09 23:07 [PATCH v3 0/3] dir: treat a repository without commits as a repository Kyle Meyer
2019-04-09 23:07 ` [PATCH v3 1/3] submodule: refuse to add repository with no commits Kyle Meyer
2019-04-09 23:07 ` [PATCH v3 2/3] dir: do not traverse repositories " Kyle Meyer
2019-04-09 23:07 ` [PATCH v3 3/3] add: error appropriately on repository " Kyle Meyer
2019-04-10  3:57 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv9zm1piq.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=debian@onerussian.com \
    --cc=git@vger.kernel.org \
    --cc=kyle@kyleam.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).