git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "LI\, BO XUAN" <liboxuan@connect.hku.hk>
Cc: git@vger.kernel.org, sunshine@sunshineco.com
Subject: Re: [PATCH v2] t4253-am-keep-cr-dos: avoid using pipes
Date: Wed, 08 May 2019 14:49:30 +0900	[thread overview]
Message-ID: <xmqqv9ylh4wl.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CALM0=-=5WeTJ2-r+u-8TYzOAih_3aCEESSpA4oKhxjRpK2yj6w@mail.gmail.com> (BO XUAN LI's message of "Tue, 7 May 2019 20:42:45 +0800")

"LI, BO XUAN" <liboxuan@connect.hku.hk> writes:

> Thanks for your review! I can understand your point, but I've got a
> quick question:
>
> What if format-patch really breaks and 'am' magically does not break?

Doesn't that indicate that you are not testing the result of "am"
adequately?

I am not saying it is *wrong* to split the pipe into two.  I am
merely saying that it is borderline Meh, as the primary point of
these two tests are to see how the command downstream of the pipe
behaves and not the upstream one.

  reply	other threads:[~2019-05-08  5:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-05  8:16 [PATCH v2] t4253-am-keep-cr-dos: avoid using pipes Boxuan Li
2019-05-07  9:04 ` Junio C Hamano
2019-05-07 12:42   ` LI, BO XUAN
2019-05-08  5:49     ` Junio C Hamano [this message]
2019-05-08 16:49       ` LI, BO XUAN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv9ylh4wl.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=liboxuan@connect.hku.hk \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).