From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Dan McGregor <dkm560@usask.ca>, "McGregor\,
Dan" <dan.mcgregor@usask.ca>,
"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH v2] git-compat-util: undefine fileno if defined
Date: Wed, 08 May 2019 19:16:16 +0900 [thread overview]
Message-ID: <xmqqv9ylfdzj.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CACsJy8BcyD199L4qGv6-TP-8HD+GS+ZDNN5jspkh5uVaWekkoQ@mail.gmail.com> (Duy Nguyen's message of "Wed, 8 May 2019 17:09:05 +0700")
Duy Nguyen <pclouds@gmail.com> writes:
> I don't think the other two were the problem. Even in the mail you
> pointed to, only fileno() is acknowledged the problem in the commit
> message.
>
> At least for BSDs fflush() and rewind() are not macros.
I can drop the dm/some-stdio-functions-are-macro-on-freebsd topic
safely then. That was the most important thing I wanted to know
about ;-)
> Let's see if there are still problems with more exotic platforms. I'm
> reluctant of adding unused compat/ code because to me compat/ is
> scary.
Right. Thanks.
prev parent reply other threads:[~2019-05-08 10:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 19:30 [PATCH] http: cast result to FILE * Dan McGregor
2019-02-01 21:17 ` Junio C Hamano
2019-02-02 11:21 ` Duy Nguyen
2019-02-04 11:44 ` Johannes Schindelin
2019-02-04 12:13 ` Duy Nguyen
2019-02-04 18:10 ` Junio C Hamano
2019-02-05 1:36 ` Dan McGregor
2019-02-09 2:36 ` [PATCH v2] git-compat-util: undefine fileno if defined Dan McGregor
2019-02-09 18:34 ` Junio C Hamano
2019-02-12 13:45 ` Duy Nguyen
2019-02-12 14:14 ` Duy Nguyen
2019-02-12 16:56 ` Junio C Hamano
2019-02-16 2:33 ` Dan McGregor
2019-05-08 7:46 ` Junio C Hamano
2019-05-08 10:09 ` Duy Nguyen
2019-05-08 10:16 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv9ylfdzj.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=dan.mcgregor@usask.ca \
--cc=dkm560@usask.ca \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).