From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 1/1] ci: split the `linux-gcc` job into two jobs
Date: Thu, 13 Jun 2019 08:56:25 -0700 [thread overview]
Message-ID: <xmqqv9x9wkba.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190613153354.GC31952@szeder.dev> ("SZEDER Gábor"'s message of "Thu, 13 Jun 2019 17:33:54 +0200")
SZEDER Gábor <szeder.dev@gmail.com> writes:
> On Thu, Jun 13, 2019 at 05:53:51AM -0700, Johannes Schindelin via GitGitGadget wrote:
>> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>>
>> This job was abused to not only run the test suite in a regular way but
>> also with all kinds of `GIT_TEST_*` options set to non-default values.
>>
>> Let's split this into two
>
> Why...?
>
>> with the `linux-gcc` job running the default
>> test suite, and the newly-introduced `linux-gcc-extra` job running the
>> test suite in the "special" ways.
>>
>> Technically, we would have to build Git only once, but it would not be
>> obvious how to teach Travis to transport build artifacts, so we keep it
>> simple and just build Git in both jobs.
I had the same reaction.
If it said something like:
There is no logical reason why these extras need to be tied to
the linux-gcc platform. instead of tying the extra
configuration tests only to linux-gcc, split it so that they are
also run on all other combinations, and this is merely a first
step of doing so
it might at least have been possible to judge if the motivation is
sane, but the proposed log message, while it is quite clear what is
being done and what its shortcomings are, is silent on why we would
want to do this in the first place, and that makes it even harder to
swallow the shortcomings.
Thanks.
next prev parent reply other threads:[~2019-06-13 15:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 12:53 [PATCH 0/1] ci: split linux-gcc into linux-gcc and linux-gcc-extra Johannes Schindelin via GitGitGadget
2019-06-13 12:53 ` [PATCH 1/1] ci: split the `linux-gcc` job into two jobs Johannes Schindelin via GitGitGadget
2019-06-13 15:33 ` SZEDER Gábor
2019-06-13 15:56 ` Junio C Hamano [this message]
2019-06-13 16:51 ` Johannes Schindelin
2019-06-13 17:43 ` SZEDER Gábor
2019-06-14 19:35 ` Johannes Schindelin
2019-06-25 8:56 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv9x9wkba.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).