From: Junio C Hamano <gitster@pobox.com>
To: "Hariom Verma via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Hariom Verma <hariom18599@gmail.com>
Subject: Re: [PATCH 0/1] builtin/blame.c: bit field constants into bit shift format
Date: Thu, 17 Oct 2019 16:33:39 +0900 [thread overview]
Message-ID: <xmqqv9sn7rn0.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <pull.382.git.1571250635.gitgitgadget@gmail.com> (Hariom Verma via GitGitGadget's message of "Wed, 16 Oct 2019 18:30:34 +0000")
"Hariom Verma via GitGitGadget" <gitgitgadget@gmail.com> writes:
> we are looking at bitfield constants, and elsewhere in the Git source code,
> such cases are handled via bit shift operators rather than octal numbers,
> which also makes it easier to spot holes in the range (if, say, 1<<5 was
> missing, it is easier to spot it between 1<<4 and 1<<6 than it is to spot a
> missing 040 between a 020 and a 0100). Also, bit shifts lead to low-level
> optimizations because they require fewer calculations for the CPU.
I think the last sentence is a nonsense for any decent compiler that
turns "1<<5" into 040 at compile time and treats it as literal
integer. Luckily, it only appears here in the cover letter and does
not appear in the patch proper, so no need to resend the patch to
correct this ;-)
next prev parent reply other threads:[~2019-10-17 7:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 18:30 [PATCH 0/1] builtin/blame.c: bit field constants into bit shift format Hariom Verma via GitGitGadget
2019-10-16 18:30 ` [PATCH 1/1] builtin/blame.c: " Hariom Verma via GitGitGadget
2019-10-16 19:10 ` Pratyush Yadav
2019-10-16 19:37 ` Jonathan Tan
2019-10-16 19:44 ` Pratyush Yadav
2019-10-17 7:38 ` Junio C Hamano
2019-10-17 7:33 ` Junio C Hamano [this message]
2019-10-17 17:46 ` [PATCH v2 0/1] builtin/blame.c: bit field " Hariom Verma via GitGitGadget
2019-10-17 17:46 ` [PATCH v2 1/1] builtin/blame.c: " Hariom Verma via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv9sn7rn0.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=hariom18599@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).