git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Emily Shaffer <emilyshaffer@google.com>
Cc: git@vger.kernel.org
Subject: Re: Change behavior of git add --patch on newly added file?
Date: Wed, 13 Nov 2019 10:47:37 +0900	[thread overview]
Message-ID: <xmqqv9roczt2.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20191112184720.GB38770@google.com> (Emily Shaffer's message of "Tue, 12 Nov 2019 10:47:20 -0800")

Emily Shaffer <emilyshaffer@google.com> writes:

>> Patches welcome, but you may want to check with Dscho as there is an
>> effort going on to reimplement the entire "add -i" machinery in C.
>
> Ah, this is a compelling point. I imagine the landscape will be fairly
> different when that effort is finished.
>
>
> From the replies, it sounds like it's a favorable change, but it makes
> sense to wait on it considering the refactor to use C. Thanks, all.

Peff's "how would you tell between genuinely untracked ones and
those you would want to add" and "should 'add -p' with no pathspec
attempt to 'add -N' everything under the sun?" are both quite valid
points.  I already raised "'add -N && add -p' would give you a
single hunk that adds everything. Are you willing to manually split,
and how well would it work?" in a separate message.  These design
issues can be resolved without coding, and should be resolved before
you start randomly typing ;-)

Thanks.

  parent reply	other threads:[~2019-11-13  1:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-08 22:50 Change behavior of git add --patch on newly added file? Emily Shaffer
2019-11-09  4:27 ` Junio C Hamano
2019-11-09  7:14   ` Junio C Hamano
2019-11-12 18:47   ` Emily Shaffer
2019-11-12 20:16     ` Johannes Schindelin
2019-11-13  1:47     ` Junio C Hamano [this message]
2019-11-11  3:41 ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv9roczt2.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=emilyshaffer@google.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).