git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: alban.gruin@gmail.com, git@vger.kernel.org, phillip.wood123@gmail.com
Subject: Re: ag/sequencer-todo-updates , was Re: What's cooking in git.git (Nov 2019, #03; Tue, 19)
Date: Wed, 20 Nov 2019 12:03:51 +0900	[thread overview]
Message-ID: <xmqqv9rfckq0.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20191119204146.168001-1-jonathantanmy@google.com> (Jonathan Tan's message of "Tue, 19 Nov 2019 12:41:46 -0800")

Jonathan Tan <jonathantanmy@google.com> writes:

>> > * ag/sequencer-todo-updates (2019-10-28) 6 commits
>> >  - SQUASH??? tentative leakfix
>> >  - sequencer: directly call pick_commits() from complete_action()
>> >  - rebase: fill `squash_onto' in get_replay_opts()
>> >  - sequencer: move the code writing total_nr on the disk to a new function
>> >  - sequencer: update `done_nr' when skipping commands in a todo list
>> >  - sequencer: update `total_nr' when adding an item to a todo list
>> > 
>> >  Reduce unnecessary reading of state variables back from the disk
>> >  during sequener operation.
>> > 
>> >  Is the leakfix patch at the tip the only thing that needs to
>> >  prepare the topic ready for 'next'?
>> > 
>> 
>> Yes, it is.
>
> I took a look at this. Some comments:

I took a look at your comments and re-read the patches and I do
agree with many of your points.

Let me not merge this round to 'next' and wait for a reroll.

Thanks for stopping me.

  reply	other threads:[~2019-11-20  3:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-19  7:05 What's cooking in git.git (Nov 2019, #03; Tue, 19) Junio C Hamano
2019-11-19  9:38 ` Danh Doan
2019-11-20  2:52   ` Junio C Hamano
2019-11-19 17:58 ` SZEDER Gábor
2019-11-20  3:02   ` Junio C Hamano
2019-11-20 13:58     ` Derrick Stolee
2019-11-21  0:36       ` Junio C Hamano
2019-11-21 11:10         ` Derrick Stolee
2019-11-22  5:42           ` Junio C Hamano
2019-11-19 18:01 ` ag/sequencer-todo-updates , was " Alban Gruin
2019-11-19 20:41   ` Jonathan Tan
2019-11-20  3:03     ` Junio C Hamano [this message]
2019-11-21  8:17       ` Alban Gruin
2019-11-23  0:47     ` Alban Gruin
2019-11-20 23:32 ` Denton Liu
2019-11-21  0:39   ` Junio C Hamano
2019-11-23 20:35 ` Philippe Blain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv9rfckq0.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=alban.gruin@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jonathantanmy@google.com \
    --cc=phillip.wood123@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).