From: Junio C Hamano <firstname.lastname@example.org> To: Jeff King <email@example.com> Cc: Taylor Blau <firstname.lastname@example.org>, email@example.com Subject: Re: [PATCH 2/5] make credential helpers builtins Date: Thu, 13 Aug 2020 10:55:30 -0700 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <20200813151410.GA892741@coredump.intra.peff.net> (Jeff King's message of "Thu, 13 Aug 2020 11:14:10 -0400") Jeff King <email@example.com> writes: > On Thu, Aug 13, 2020 at 11:08:39AM -0400, Taylor Blau wrote: > >> On Thu, Aug 13, 2020 at 10:58:55AM -0400, Jeff King wrote: >> > There's no real reason for credential helpers to be separate binaries. I >> > did them this way originally under the notion that helper don't _need_ >> > to be part of Git, and so can be built totally separately (and indeed, >> > the ones in contrib/credential are). But the ones in our main Makefile >> > build on libgit.a, and the resulting binaries are reasonably large. >> >> Could you clarify which helpers you mean here? Git's own >> credential-cache and store make sense to convert, but the helpers in >> contrib definitely don't. >> >> For what it's worth, I'm almost positive that you mean the in-tree >> helpers (where in-tree means "in git.git but not in contrib"), in which >> case I'm in favor of this direcftion. > > Yes, I mean the helpers in the Makefile that we build and install by > default with a regular "make". Makes sense, especially because none of the in-tree ones need to link with any extra dependency at runtime, we do not even have to debate if dynamic linkage overhead still matters ;-)
next prev parent reply other threads:[~2020-08-13 17:55 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-13 14:55 [PATCH 0/5] slimming down installed size Jeff King 2020-08-13 14:57 ` [PATCH 1/5] Makefile: drop builtins from MSVC pdb list Jeff King 2020-08-13 15:04 ` Taylor Blau 2020-08-13 15:08 ` Jeff King 2020-08-13 16:37 ` Derrick Stolee 2020-08-13 17:40 ` Jeff King 2020-08-14 14:18 ` Johannes Schindelin 2020-08-14 14:32 ` Jeff King 2020-08-17 4:42 ` Johannes Schindelin 2020-08-17 13:20 ` Jeff Hostetler 2020-08-13 14:58 ` [PATCH 2/5] make credential helpers builtins Jeff King 2020-08-13 15:08 ` Taylor Blau 2020-08-13 15:14 ` Jeff King 2020-08-13 17:55 ` Junio C Hamano [this message] 2020-08-13 14:59 ` [PATCH 3/5] make git-bugreport a builtin Jeff King 2020-08-13 17:01 ` Derrick Stolee 2020-08-13 17:38 ` Jeff King 2020-08-13 18:25 ` Junio C Hamano 2020-08-13 18:47 ` Junio C Hamano 2020-08-14 10:13 ` Jeff King 2020-08-14 14:25 ` Johannes Schindelin 2020-08-14 10:05 ` Jeff King 2020-08-13 18:01 ` Junio C Hamano 2020-08-14 14:28 ` Johannes Schindelin 2020-08-15 6:38 ` Jeff King 2020-08-17 12:12 ` Emily Shaffer 2020-08-17 16:58 ` Junio C Hamano 2020-08-17 21:40 ` Jeff King 2020-08-17 12:16 ` Emily Shaffer 2020-08-13 14:59 ` [PATCH 4/5] make git-fast-import " Jeff King 2020-08-13 15:00 ` [PATCH 5/5] drop vcs-svn experiment Jeff King 2020-08-13 15:11 ` Taylor Blau 2020-08-13 15:18 ` Jeff King 2020-08-14 14:39 ` Johannes Schindelin 2020-08-14 15:11 ` Jeff King 2020-08-13 15:13 ` [PATCH 0/5] slimming down installed size Taylor Blau
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 2/5] make credential helpers builtins' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).