From: Junio C Hamano <gitster@pobox.com>
To: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] t3404: do not depend on any specific default branch name
Date: Tue, 24 Nov 2020 13:16:42 -0800 [thread overview]
Message-ID: <xmqqv9duihfp.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <pull.798.git.1606212950283.gitgitgadget@gmail.com> (Johannes Schindelin via GitGitGadget's message of "Tue, 24 Nov 2020 10:15:49 +0000")
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> Now that we can override the default branch name in the tests via
> `GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME`, we should avoid expecting a
> particular hard-coded name.
>
> So let's rename the initial branch immediately to `primary` and work
> with that.
Yes, that is probably the approach that gives us the most stable
environment to work in. I like it.
> Applying this patch would obsolete the change in
> js/default-branch-name-tests-final-stretch to force the default branch
> name to master in t3404.
Yup, after taking these individual replacement patches, I expect
that the big topic will see shrinkage, which is good.
Will queue. Thanks.
prev parent reply other threads:[~2020-11-24 22:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 10:15 [PATCH] t3404: do not depend on any specific default branch name Johannes Schindelin via GitGitGadget
2020-11-24 21:16 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv9duihfp.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).