From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 281A01F4B4 for ; Wed, 6 Jan 2021 02:05:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725800AbhAFCFM (ORCPT ); Tue, 5 Jan 2021 21:05:12 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:63900 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbhAFCFM (ORCPT ); Tue, 5 Jan 2021 21:05:12 -0500 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 6559FAD8A1; Tue, 5 Jan 2021 21:04:30 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=L+1UoHsif136b390Xl3F2Wty5YU=; b=jOKyqI Jkhzrh398zUGEqpAOidSx+lRW8xvrsvabyKiVzCec6T8wMNfBmwTBkL/NFmyoMLl yp0GQq0YRGP1Wz8wyv9ZuGJMvuwiSJ2j5wKqwFYs1YQd0XAi4QBQeYWO5GIebIP6 2cfheIMb4cP/5Ce2vZPLU+XQEpkE+2ywU/U0w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=mBup/LKZWq9L2xgWsfqBaNMBpL/eOTug HJbAZ0Px08gdf+A+L/qeL5DquJMBqE1K7mMRj0dQmUqw41nzIts3hCyx6Xd0mFsg SX0qxtEHiJPq53MiWfmE66X0+DvgIshVpHu8sIdgQdY43HSyTyQYmH+RM9fxnVjV iEMgi52J3gw= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 5C854AD8A0; Tue, 5 Jan 2021 21:04:30 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [35.196.173.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id DFBD4AD89F; Tue, 5 Jan 2021 21:04:29 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Alban Gruin Cc: Derrick Stolee , git@vger.kernel.org, Phillip Wood Subject: Re: [PATCH v6 06/13] merge-index: don't fork if the requested program is `git-merge-one-file' References: <20201116102158.8365-1-alban.gruin@gmail.com> <20201124115315.13311-1-alban.gruin@gmail.com> <20201124115315.13311-7-alban.gruin@gmail.com> <44c9189d-9d2f-c437-d0d6-9529708d2c99@gmail.com> <411b68ad-dee5-5a19-ae94-c2b6a249161a@gmail.com> Date: Tue, 05 Jan 2021 18:04:29 -0800 In-Reply-To: <411b68ad-dee5-5a19-ae94-c2b6a249161a@gmail.com> (Alban Gruin's message of "Wed, 6 Jan 2021 00:20:33 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 82F624F8-4FC3-11EB-960E-D152C8D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Alban Gruin writes: > We had the same discussion with Phillip, who pointed out this previous > discussion about this topic: > https://lore.kernel.org/git/xmqqblv5kr9u.fsf@gitster-ct.c.googlers.com/ > > So, it's probably OK to do that. These days, there exists an optional installation option exists that won't even install built-in commands in $GIT_EXEC_PATH, which invalidates the assessment made in 2019 in the article you cited above, so the code might still be OK, but the old justification no longer would apply. In any case, if two people who reviewed a patch found the same thing in it fishy, it is an indication that the reason why the apparently fishy code is OK needs to be better explained so that future readers of the code do not have to be puzzled about the same thing. Thanks.