From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id F16D81F9FD for ; Fri, 12 Mar 2021 22:10:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235440AbhCLWJl (ORCPT ); Fri, 12 Mar 2021 17:09:41 -0500 Received: from pb-smtp1.pobox.com ([64.147.108.70]:53493 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235375AbhCLWJe (ORCPT ); Fri, 12 Mar 2021 17:09:34 -0500 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 7092FAF3B0; Fri, 12 Mar 2021 17:09:34 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=k1AaNV+2FpLAZJ/8f865fosgn5s=; b=j2+det pJMjgY3MazpESkn7HeXrVy/v40og5yzy2LbWLy0MkwVjBFbXp+ernUVAenN6HaF+ aW4Ue0Lvu0AWfdqDrJRMkgSCVePiJZTm+NJ+jZtDLctuBxTmcm8UR95TNviuc77A GBq9uuKvfLg0H4ckSlzVCIJjdDqwG8vU4OaYM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; q=dns; s=sasl; b=iUs/xXwlPiRWt4ttFqGoI5NvaE9cTe0w 6QnBiNHMx+1sRTDujWLqxLLjKRbN457zSwk7sh13fxq+JdoK/+URSeaoy8OViJm1 U5MbBUjmOoci96CL3VOnjL2CKdu0VCH1vLp6ZAAhDVZyu8yyOpha11vkZXzPdYtv I4CoQoGHPxc= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 681EBAF3AF; Fri, 12 Mar 2021 17:09:34 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id D9CF8AF3AE; Fri, 12 Mar 2021 17:09:33 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Taylor Blau Cc: ZheNing Hu via GitGitGadget , git@vger.kernel.org, Johannes Schindelin , Denton Liu , Taylor Blau , ZheNing Hu Subject: Re: [PATCH] [GSOC][RFC] format-patch: pass --right-only to range-diff In-Reply-To: (Junio C. Hamano's message of "Fri, 12 Mar 2021 13:55:07 -0800") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (gnu/linux) Date: Fri, 12 Mar 2021 14:09:33 -0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: A0581250-837F-11EB-837C-D152C8D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Junio C Hamano writes: > Taylor Blau writes: > >> Note that I think (and Johannes--cc'd--could confirm) that what you want >> is '--left-only' to discard rebased changes from the upstream branch: > > Does that mean range-diff got --left-only and --right-only > backwards? IOW, doesn't > > $ git log --left-only A...B > > show what is shown in "git log B..A", and if so, shouldn't > > $ git range-diff --left-only A...B > > which is a synonym for > > $ git range-diff B..A A..B > > also give commits in the B..A range? > > Puzzled.... Ah, it was only that "range-diff --help" uses confusing double-negative phrasing. I.e. --left-only:: Suppress commits that are missing from the first specified range (or the "left range" when using the `...` format). If you "suppress those that are missing from X", you are effectively including only those that appear in X, so two conclusions I draw are - "range-diff" does not get "--left/right-only" backwards; - its documentation should be improved. Perhaps --left-only:: Include only commits that are in the first range (or the "left range" when using the `...` format). wouldn't have made me puzzled. Thanks.