git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Bagas Sanjaya <bagasdotme@gmail.com>, git@vger.kernel.org
Subject: Re: Reviewed-by given by celebrities (no subject matter expertise on Git development)
Date: Wed, 07 Apr 2021 13:57:10 -0700	[thread overview]
Message-ID: <xmqqv98xyfrt.fsf@gitster.g> (raw)
In-Reply-To: <YG4U5phu1uXZe6Tn@coredump.intra.peff.net> (Jeff King's message of "Wed, 7 Apr 2021 16:24:06 -0400")

Jeff King <peff@peff.net> writes:

> I don't usually post "me too" responses, since they are usually just
> noise. But I could not resist it here, for two reasons:
>
>   - this is such a nicely written summary of what "Reviewed-by" means in
>     our project that I think it deserves some praise. :)
>
>   - because it is ultimately about "what does Reviewed-by mean within
>     the Git project", there is some small value in having another
>     project member say "yes, that is exactly what I expect from it,
>     too"

Heh, thanks.

Are you hinting that some of what I wrote (with typofixes like
s/arond/around/) should be inserted to SubmittingPatches or
somewhere near it?

I am still scratching my head why "celebrities" were brought into
the original question in the first place, but I can say that we do
not discriminate against "celebrities" who review patches with
prejudice like "that lady only plays a hacker on TV, and must know
nothing to qualify to review our patches."  Celebrities or not, once
somebody demonstrates enough competence and earns reputation on this
list, opinions by that person would count more than others.

  reply	other threads:[~2021-04-07 20:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-02  5:45 Reviewed-by given by celebrities (no subject matter expertise on Git development) Bagas Sanjaya
2021-04-04  2:27 ` Junio C Hamano
2021-04-07 20:24   ` Jeff King
2021-04-07 20:57     ` Junio C Hamano [this message]
2021-04-07 21:18       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv98xyfrt.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=bagasdotme@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).