From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.2 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id AE8611F8C6 for ; Sat, 7 Aug 2021 17:01:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229803AbhHGRBy (ORCPT ); Sat, 7 Aug 2021 13:01:54 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:54949 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229894AbhHGRBL (ORCPT ); Sat, 7 Aug 2021 13:01:11 -0400 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 58A4FF5229; Sat, 7 Aug 2021 13:00:53 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=xG1ro0g+yARC5eBAal1HfpwEEwUxE1XxncvhbJ n87eU=; b=ZuU9KOw8nF2kH22Ylt6J3EyyYf8aYJn+A2SeokOn4pQzcAK1JDc04b K2Gzy/sKErZnWgRW9RrZLnRZxGwl48hVrqLJ0ASKafqdUG88oYCbzMtHuMS7OVfk jGSYMSdHO0X8VG59EYr6s2jBOdLy+L74LwQo+3ssqBhRnKk/TH7fo= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 4DAA6F5228; Sat, 7 Aug 2021 13:00:53 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.3.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id C9249F5227; Sat, 7 Aug 2021 13:00:52 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Jonathan Nieder Cc: Johannes Sixt , Sergey Organov , Jeff King , Philip Oakley , Elijah Newren , Felipe Contreras , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Alex Henrie , huang guanlong , git@vger.kernel.org, Hudson Ayers , Taylor Yu , Joshua Nelson Subject: Re: [PATCH] Revert 'diff-merges: let "-m" imply "-p"' References: <20210520214703.27323-1-sorganov@gmail.com> <20210520214703.27323-11-sorganov@gmail.com> <035b4e99-e708-f31b-2f13-e255d99dea33@kdbg.org> Date: Sat, 07 Aug 2021 10:00:51 -0700 In-Reply-To: (Jonathan Nieder's message of "Sat, 7 Aug 2021 06:51:12 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 06101DE6-F7A1-11EB-AF25-8B3BC6D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jonathan Nieder writes: > More generally, we've been able to make changes to porcelain commands > that don't hurt our ability to act as a platform for scripts, and I > want us to continue to be able to do that. "Do not break any script" > is certainly not the standard I think we should apply, as illustrated > by my thoughts upthread when I thought '-m' in this Rust example was a > typo. > > But by now it's very clear to me that it was not a typo. This is a tangent that does not change the conclusion, because the use of "-m" in "stash list" was not a typo but a deliberate attempt to allow "-p" from the end-users to do what they wanted to do, and it was clearly broken by this change (as you said, the need to hide the breakage in the same series should have ringed a loud bell for us). But I didn't see how you think your Rust thing is not a typo, and I still don't. Unless you think Rust folks expected "-m" to do what "-m" was not designed to do, that is, and I do not think that "people thought it did something entirely differently, when it was a no-op, so we shouldn't suddenly make it not a no-op" is a good rationale that affects how we choose the evolution path for our tools. THanks.