From: Junio C Hamano <gitster@pobox.com>
To: Bruno Albuquerque <bga@google.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Jeff King" <peff@peff.net>, "Stef Bon" <stefbon@gmail.com>,
"Git Users" <git@vger.kernel.org>
Subject: Re: Exec upload-pack on remote with what parameters to get direntries.
Date: Tue, 31 Aug 2021 09:23:08 -0700 [thread overview]
Message-ID: <xmqqv93lwplf.fsf@gitster.g> (raw)
In-Reply-To: <CAPeR6H7_V+ypzyN39e27+NCRqG-nA17sgq=qtefzFF3Dg50bnA@mail.gmail.com> (Bruno Albuquerque's message of "Tue, 31 Aug 2021 08:35:22 -0700")
Bruno Albuquerque <bga@google.com> writes:
> With all that being said, I don' t think making it optional would be
> an issue so I have no strong feelings about this. I am fine with
> whatever is agreed to be the best approach.
>
>> I found myself wondering this when reading serve.c the other day,
>> i.e. why we have "always_advertise" for object-info, but it seemed
>> innocuous enough given how it's described in a2ba162cda2 (object-info:
>> support for retrieving object info, 2021-04-20).
> For what it is worth, The same change is now being reviewed in JGit
> and there the feature is conditionally enabled. But that was a
> side-effect of needing to deploy it to multiple servers before making
> the feature available to clients.
FWIW, I do not mind, and probably prefer if I think about it a bit
longer, to make it an opt-in feature, like all other capabilities
defined in the serve.c file.
Thanks.
next prev parent reply other threads:[~2021-08-31 16:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-28 12:56 Exec upload-pack on remote with what parameters to get direntries Stef Bon
2021-08-30 19:10 ` Jeff King
2021-08-30 19:43 ` Junio C Hamano
2021-08-30 20:46 ` Jeff King
2021-08-30 21:21 ` Junio C Hamano
2021-08-31 14:23 ` Ævar Arnfjörð Bjarmason
2021-08-31 15:35 ` Bruno Albuquerque
2021-08-31 16:23 ` Junio C Hamano [this message]
2021-08-31 6:38 ` Stef Bon
2021-08-31 7:07 ` Jeff King
2021-08-31 9:44 ` Stef Bon
2021-08-31 14:01 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv93lwplf.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=bga@google.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=stefbon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).