From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id B07BA1F953 for ; Mon, 13 Dec 2021 19:29:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238445AbhLMT3Z (ORCPT ); Mon, 13 Dec 2021 14:29:25 -0500 Received: from pb-smtp20.pobox.com ([173.228.157.52]:64254 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236101AbhLMT3Y (ORCPT ); Mon, 13 Dec 2021 14:29:24 -0500 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 1BEEA15FF35; Mon, 13 Dec 2021 14:29:24 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=jNqGdbFFgvlZpCaEInoXGi+lkxbCr5GQPso8qq NwQRY=; b=LqMZWfxoeC3Zupz5djIG5W3hbPxRh2MYR+ND0JKNEbrE1X5cpiKdku gnzRavGrvHWi6AoEAJP+xOBDuEW55nTpXPzxx4pY2HrNnziOWSoVnRKRZZnpyDiq 5HDDiZUrNe56ku3jAAlv7TUsQ8CasuNMMnjGQdr/Q6vO7SKbTTTF8= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 120FE15FF34; Mon, 13 Dec 2021 14:29:24 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [104.133.2.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 612B615FF32; Mon, 13 Dec 2021 14:29:20 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Joel Holdsworth Cc: Luke Diamand , Git Users Subject: Re: [PATCH 0/6] Transition git-p4.py to support Python 3 only References: <20211209201029.136886-1-jholdsworth@nvidia.com> Date: Mon, 13 Dec 2021 11:29:19 -0800 In-Reply-To: (Joel Holdsworth's message of "Mon, 13 Dec 2021 13:47:49 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: F842E63A-5C4A-11EC-B677-F327CE9DA9D6-77302942!pb-smtp20.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Joel Holdsworth writes: >> > What unit tests are these? I am happy to test with them. >> >> cd t >> make T=t98* -j$(nproc) > > Awesome! Just ran the tests. We got a clean sweep. > > With one proviso: > > When running the current upstream master git-p4 version, there are errors if /usr/bin/python is not present. > > lib-git-p4.sh checks for the presence of python with "test_have_prereq PYTHON" - but if I only have /usr/bin/python3 installed, the prerequisite check passes, but git-p4.py itself fails because the shebang points at python not python3. > > On Debian installing the package "python-is-python3" fixes the issue. Can I take that a distro allowing an installation without python-is-python3 (or just having only python2) as a sign that "transtion to 3 only" is a bit premature? > Perhaps it might help to have something like "test_have_prereq PYTHON3". Sure, but that defeats the whole notion of "python3 is everywhere, python2 is dead, and nobody should be using the 2-year dead version". "test_have_prereq PYTHON" should be sufficient in such a world, no?