From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 5D0891F852 for ; Mon, 31 Jan 2022 22:42:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234425AbiAaWmF (ORCPT ); Mon, 31 Jan 2022 17:42:05 -0500 Received: from pb-smtp20.pobox.com ([173.228.157.52]:64315 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234386AbiAaWmD (ORCPT ); Mon, 31 Jan 2022 17:42:03 -0500 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id B2ECA165A75; Mon, 31 Jan 2022 17:42:03 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=0EdLtNjvVyzU wralPpyzA5xxiXlTxUEmebMrsQUmvQs=; b=M6XMvaDCY5niKZWDejzvR0rK66Oj yXMQJuYe8lOIAorysyuI2954yY3UWvvYHwEyJhOhXWpA2obcKOjW3kJpYKc+zuzJ GGAqN4HKKNQYk2wsWwPNsV6M94k/83zYoV8inQJEDfOeOOPGAME2JxN2mpXnrQFz MfbO/DVxrYEReYk= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id AB49A165A74; Mon, 31 Jan 2022 17:42:03 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [104.133.2.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 1D0EC165A6F; Mon, 31 Jan 2022 17:42:01 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?Q?Jean-No=C3=ABl_Avila_via_GitGitGadget?= Cc: git@vger.kernel.org, Johannes Sixt , Phillip Wood , =?utf-8?Q?Jean-No=C3=ABl?= Avila Subject: Re: [PATCH v4 1/4] i18n: factorize more 'incompatible options' messages References: <2eac2ef502b86d0c15513c8d0e69928ce2140b1f.1643666870.git.gitgitgadget@gmail.com> Date: Mon, 31 Jan 2022 14:41:59 -0800 In-Reply-To: <2eac2ef502b86d0c15513c8d0e69928ce2140b1f.1643666870.git.gitgitgadget@gmail.com> (=?utf-8?Q?=22Jean-No=C3=ABl?= Avila via GitGitGadget"'s message of "Mon, 31 Jan 2022 22:07:46 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 013AFDFA-82E7-11EC-BF27-C85A9F429DF0-77302942!pb-smtp20.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "Jean-No=C3=ABl Avila via GitGitGadget" writes: > +inline void die_for_incompatible_opt3(int opt1, const char *opt1_name, > + int opt2, const char *opt2_name, > + int opt3, const char *opt3_name) > +{ > + die_for_incompatible_opt4(opt1, opt1_name, > + opt2, opt2_name, > + opt3, opt3_name, > + 0, ""); > +} I haven't seen a non-static inline function defined in a common header files. Does this actually work? In my build, ld choked on this one. Otherwise make it "static inline"? Or just #define die_for_incompatible_opt3(o1,n1,o2,n2,o3,n3) \ die_for_incompatible_opt4((o1), (n1), \ (o2), (n2), \ (o3), (n3), \ 0, "") perhaps?