From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Chris Down <chris@chrisdown.name>,
git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Christian Couder <chriscool@tuxfamily.org>,
kernel-team@fb.com
Subject: Re: [PATCH v2 2/2] bisect: output bisect setup status in bisect log
Date: Mon, 09 May 2022 09:08:46 -0700 [thread overview]
Message-ID: <xmqqv8ueelip.fsf@gitster.g> (raw)
In-Reply-To: <Ynk2q1XVGsLPvALn@nand.local> (Taylor Blau's message of "Mon, 9 May 2022 11:43:39 -0400")
Taylor Blau <me@ttaylorr.com> writes:
> On Fri, May 06, 2022 at 11:18:25AM -0700, Junio C Hamano wrote:
>> Chris Down <chris@chrisdown.name> writes:
>>
>> > +__attribute__((format (printf, 1, 2)))
>> > +static void bisect_log_printf(const char *fmt, ...)
>> > +{
>> > + va_list ap;
>> > + char buf[1024];
>> > +
>> > + va_start(ap, fmt);
>> > + if (vsnprintf(buf, sizeof(buf), fmt, ap) < 0)
>> > + *buf = '\0';
>> > + va_end(ap);
>>
>> We should just do
>>
>> struct strbuf buf = STRBUF_INIT;
>>
>> va_start(ap, fmt);
>> strbuf_vaddf(&buf, fmt, ap);
>> va_end(ap);
>>
>> > + printf("%s", buf);
>> > + append_to_file(git_path_bisect_log(), "# %s", buf);
>>
>> and free the resource with
>>
>> strbuf_release(&buf);
>>
>> I think.
>
> I don't think so. bisect_log_printf() has only one caller, which is
> bisect_print_status(). Couldn't the latter manage its own strbuf without
> the need to introduce a new varargs function?
I actually was hoping that other existing informational messages
prefixed with "Bisecting:" (i.e. those that tells you how many steps
are remaining) can go as similar comments to the log file; they are
currently written with plain-vanilla printf(3), and could use this
one instead.
next prev parent reply other threads:[~2022-05-09 16:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 0:52 [PATCH v2 0/2] bisect: status improvements when bisect is not fully fleshed out Chris Down
2022-05-06 0:52 ` [PATCH v2 1/2] bisect: output state before we are ready to compute bisection Chris Down
2022-05-06 2:52 ` Taylor Blau
2022-05-06 10:14 ` Chris Down
2022-05-06 16:42 ` Junio C Hamano
2022-05-06 18:12 ` Junio C Hamano
2022-05-06 0:52 ` [PATCH v2 2/2] bisect: output bisect setup status in bisect log Chris Down
2022-05-06 3:03 ` Taylor Blau
2022-05-06 10:09 ` Chris Down
2022-05-09 15:41 ` Taylor Blau
2022-05-06 16:57 ` Junio C Hamano
2022-05-06 16:47 ` Junio C Hamano
2022-05-06 18:18 ` Junio C Hamano
2022-05-09 15:43 ` Taylor Blau
2022-05-09 16:08 ` Junio C Hamano [this message]
2022-05-09 16:27 ` Taylor Blau
2022-05-07 10:58 ` [PATCH v2 0/2] bisect: status improvements when bisect is not fully fleshed out Chris Down
2022-05-07 18:25 ` Junio C Hamano
2022-05-07 21:22 ` Chris Down
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv8ueelip.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chris@chrisdown.name \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=kernel-team@fb.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).