git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Victoria Dye <vdye@github.com>,
	Taylor Blau <me@ttaylorr.com>,
	Emily Shaffer <emilyshaffer@google.com>,
	Jonathan Nieder <jrnieder@gmail.com>,
	John Cai <johncai86@gmail.com>,
	Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH v3 04/36] blame: use a more detailed usage_msg_optf() error on bad -L
Date: Fri, 30 Sep 2022 14:00:50 -0700	[thread overview]
Message-ID: <xmqqv8p4a871.fsf@gitster.g> (raw)
In-Reply-To: <patch-v3-04.36-a8312c50f01-20220930T180415Z-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Fri, 30 Sep 2022 20:07:27 +0200")

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> Improve the error message emitted when there's a bad -L argument, and
> do so using the parse-options.c flavor of "usage()", instead of using
> the non-parse-options.c usage() function. This was the last user of
> usage() in this file.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  builtin/blame.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

This may not be incorrect (I didn't spend time to see if this "while
at it" is truly an improvement) but clearly outside the scome of
"output from the -h option should match synopsis" theme.

> diff --git a/builtin/blame.c b/builtin/blame.c
> index a9fe8cf7a68..8ec59fa2096 100644
> --- a/builtin/blame.c
> +++ b/builtin/blame.c
> @@ -1108,12 +1108,13 @@ int cmd_blame(int argc, const char **argv, const char *prefix)
>  	anchor = 1;
>  	range_set_init(&ranges, range_list.nr);
>  	for (range_i = 0; range_i < range_list.nr; ++range_i) {
> +		const char *arg = range_list.items[range_i].string;
>  		long bottom, top;
> -		if (parse_range_arg(range_list.items[range_i].string,
> -				    nth_line_cb, &sb, lno, anchor,
> +		if (parse_range_arg(arg, nth_line_cb, &sb, lno, anchor,
>  				    &bottom, &top, sb.path,
>  				    the_repository->index))
> -			usage(blame_usage);
> +			usage_msg_optf(_("failed to parse -L argument '%s'"),
> +				       blame_opt_usage, options, arg);

So, it used to be that it emitted only blame_usage which is a rough
match to the synopsis, 

    "git blame [<options>] [<rev-opts>] [<rev>] [--] <file>"

but now we use blame_opt_usage + options, which means that the same
blame_usage, a blank line, and "<rev-opts> are documented in
git-rev-list(1)" is given, followed by the list of full options. 

I do think saying "failed to parse -L" is an improvement, but it is
dubious it is a good idea to follow it with a wall of text that
comes from options[].  After all, if the user chose to use "-L 2,8"
and a typo replaced the comma with a full stop, which caused
parse_range_arg() to fail, does it make sense to scroll away the
message that helpfully points out that "-L argument '2.8'" was the
problem with other option descriptions?

This is why we shouldn't distract a series with "while at it"
changes that are outside the scope of the theme.  Letting the patch
authors and reviewers concentrate on doing one thing well would
avoid mistakes, but mixing unrelated changes distracts them.  Having
to think about the differences between usage() and usage_msg_optf()
with this change already distracted me and stopped my review on this
series in this sitting.  The topic will need to wait for the next
time I decide to sit with it and start reading it from the next step.

And of course, a series like this, which is supposed to do the same
thing to many files for consistency, is better written and reviewed
in one sitting, because that will make it easier in reviewers' mind
to keep and apply the same review criteria consistently.

>  		if ((!lno && (top || bottom)) || lno < bottom)
>  			die(Q_("file %s has only %lu line",
>  			       "file %s has only %lu lines",

  reply	other threads:[~2022-09-30 21:01 UTC|newest]

Thread overview: 230+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-05  8:26 [PATCH 00/34] doc/UX: make txt & -h output more consistent Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 01/34] CodingGuidelines: update and clarify command-line conventions Ævar Arnfjörð Bjarmason
2022-09-07 20:19   ` Junio C Hamano
2022-09-08  7:46     ` Ævar Arnfjörð Bjarmason
2022-09-08 16:41       ` Junio C Hamano
2022-09-05  8:26 ` [PATCH 02/34] builtin/bundle.c: use \t, not fix indentation 2-SP indentation Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 03/34] bundle: define subcommand -h in terms of command -h Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 04/34] blame: use a more detailed usage_msg_optf() error on bad -L Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 05/34] doc SYNOPSIS: don't use ' for subcommands Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 06/34] doc SYNOPSIS: consistently use ' for commands Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 07/34] doc SYNOPSIS & -h: fix incorrect alternates syntax Ævar Arnfjörð Bjarmason
2022-09-19 22:09   ` Victoria Dye
2022-09-26 11:28     ` Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 08/34] built-ins: consistently add "\n" between "usage" and options Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 09/34] doc txt & -h consistency: word-wrap Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 10/34] doc txt & -h consistency: fix incorrect alternates syntax Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 11/34] doc txt & -h consistency: add "-z" to cat-file "-h" Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 12/34] doc txt & -h consistency: add missing "]" to bugreport "-h" Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 13/34] doc txt & -h consistency: correct padding around "[]()" Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 14/34] stash doc SYNOPSIS & -h: " Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 15/34] doc txt & -h consistency: use "<options>", not "<options>..." Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 16/34] t/helper/test-proc-receive.c: " Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 17/34] doc txt & -h consistency: fix mismatching labels Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 18/34] doc txt & -h consistency: add or fix optional "--" syntax Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 19/34] doc txt & -h consistency: make output order consistent Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 20/34] doc txt & -h consistency: add missing options and labels Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 21/34] doc txt & -h consistency: make "rerere" consistent Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 22/34] doc txt & -h consistency: make "read-tree" consistent Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 23/34] doc txt & -h consistency: make "bundle" consistent Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 24/34] doc txt & -h consistency: use "git foo" form, not "git-foo" Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 25/34] doc txt & -h consistency: add missing options Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 26/34] doc txt & -h consistency: make "stash" consistent Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 27/34] doc txt & -h consistency: make "annotate" consistent Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 28/34] doc txt & -h consistency: use "[<label>...]" for "zero or more" Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 29/34] doc txt & -h consistency: make "diff-tree" consistent Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 30/34] doc txt & -h consistency: make "commit" consistent Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 31/34] reflog doc: list real subcommands up-front Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 32/34] worktree: define subcommand -h in terms of command -h Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 33/34] doc txt & -h consistency: make "worktree" consistent Ævar Arnfjörð Bjarmason
2022-09-05  8:26 ` [PATCH 34/34] tests: start asserting that *.txt SYNOPSIS matches -h output Ævar Arnfjörð Bjarmason
2022-09-19 22:15 ` [PATCH 00/34] doc/UX: make txt & -h output more consistent Victoria Dye
2022-09-20  0:57   ` Victoria Dye
2022-09-28  8:38 ` [PATCH v2 00/35] " Ævar Arnfjörð Bjarmason
2022-09-28  8:38   ` [PATCH v2 01/35] CodingGuidelines: update and clarify command-line conventions Ævar Arnfjörð Bjarmason
2022-09-28 17:29     ` Junio C Hamano
2022-09-30 17:09       ` Junio C Hamano
2022-09-30 17:27         ` Ævar Arnfjörð Bjarmason
2022-09-28  8:38   ` [PATCH v2 02/35] builtin/bundle.c: use \t, not fix indentation 2-SP indentation Ævar Arnfjörð Bjarmason
2022-09-28 23:35     ` Eric Sunshine
2022-09-28  8:38   ` [PATCH v2 03/35] bundle: define subcommand -h in terms of command -h Ævar Arnfjörð Bjarmason
2022-09-28  8:38   ` [PATCH v2 04/35] blame: use a more detailed usage_msg_optf() error on bad -L Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 05/35] doc SYNOPSIS: don't use ' for subcommands Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 06/35] doc SYNOPSIS: consistently use ' for commands Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 07/35] doc SYNOPSIS & -h: fix incorrect alternates syntax Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 08/35] built-ins: consistently add "\n" between "usage" and options Ævar Arnfjörð Bjarmason
2022-09-28 23:51     ` Eric Sunshine
2022-09-28  8:39   ` [PATCH v2 09/35] doc txt & -h consistency: word-wrap Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 10/35] doc txt & -h consistency: fix incorrect alternates syntax Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 11/35] doc txt & -h consistency: add "-z" to cat-file "-h" Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 12/35] doc txt & -h consistency: add missing "]" to bugreport "-h" Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 13/35] doc txt & -h consistency: correct padding around "[]()" Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 14/35] stash doc SYNOPSIS & -h: " Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 15/35] doc txt & -h consistency: use "<options>", not "<options>..." Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 16/35] t/helper/test-proc-receive.c: " Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 17/35] doc txt & -h consistency: fix mismatching labels Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 18/35] doc txt & -h consistency: add or fix optional "--" syntax Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 19/35] doc txt & -h consistency: make output order consistent Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 20/35] doc txt & -h consistency: add missing options and labels Ævar Arnfjörð Bjarmason
2022-09-29  3:04     ` Eric Sunshine
2022-09-28  8:39   ` [PATCH v2 21/35] doc txt & -h consistency: make "rerere" consistent Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 22/35] doc txt & -h consistency: make "read-tree" consistent Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 23/35] doc txt & -h consistency: make "bundle" consistent Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 24/35] doc txt & -h consistency: use "git foo" form, not "git-foo" Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 25/35] doc txt & -h consistency: add missing options Ævar Arnfjörð Bjarmason
2022-09-29  4:36     ` Eric Sunshine
2022-09-28  8:39   ` [PATCH v2 26/35] doc txt & -h consistency: make "stash" consistent Ævar Arnfjörð Bjarmason
2022-09-29  4:41     ` Eric Sunshine
2022-09-28  8:39   ` [PATCH v2 27/35] doc txt & -h consistency: make "annotate" consistent Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 28/35] doc txt & -h consistency: use "[<label>...]" for "zero or more" Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 29/35] doc txt & -h consistency: make "diff-tree" consistent Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 30/35] doc txt & -h consistency: make "commit" consistent Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 31/35] reflog doc: list real subcommands up-front Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 32/35] worktree: define subcommand -h in terms of command -h Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 33/35] doc txt & -h consistency: make "worktree" consistent Ævar Arnfjörð Bjarmason
2022-09-28  8:39   ` [PATCH v2 34/35] tests: start asserting that *.txt SYNOPSIS matches -h output Ævar Arnfjörð Bjarmason
2022-09-28 20:27     ` Junio C Hamano
2022-09-28  8:39   ` [PATCH v2 35/35] tests: assert consistent whitespace in " Ævar Arnfjörð Bjarmason
2022-09-28 18:04   ` [PATCH v2 00/35] doc/UX: make txt & -h output more consistent Junio C Hamano
2022-09-28 20:10     ` Ævar Arnfjörð Bjarmason
2022-09-30 18:07   ` [PATCH v3 00/36] " Ævar Arnfjörð Bjarmason
2022-09-30 18:07     ` [PATCH v3 01/36] CodingGuidelines: update and clarify command-line conventions Ævar Arnfjörð Bjarmason
2022-09-30 21:01       ` Junio C Hamano
2022-09-30 18:07     ` [PATCH v3 02/36] builtin/bundle.c: indent with tabs Ævar Arnfjörð Bjarmason
2022-09-30 21:01       ` Junio C Hamano
2022-09-30 18:07     ` [PATCH v3 03/36] bundle: define subcommand -h in terms of command -h Ævar Arnfjörð Bjarmason
2022-09-30 21:01       ` Junio C Hamano
2022-09-30 18:07     ` [PATCH v3 04/36] blame: use a more detailed usage_msg_optf() error on bad -L Ævar Arnfjörð Bjarmason
2022-09-30 21:00       ` Junio C Hamano [this message]
2022-10-03  8:36         ` Ævar Arnfjörð Bjarmason
2022-09-30 18:07     ` [PATCH v3 05/36] doc SYNOPSIS: don't use ' for subcommands Ævar Arnfjörð Bjarmason
2022-09-30 21:23       ` Junio C Hamano
2022-09-30 18:07     ` [PATCH v3 06/36] doc SYNOPSIS: consistently use ' for commands Ævar Arnfjörð Bjarmason
2022-09-30 18:07     ` [PATCH v3 07/36] doc SYNOPSIS & -h: fix incorrect alternates syntax Ævar Arnfjörð Bjarmason
2022-09-30 21:28       ` Junio C Hamano
2022-09-30 18:07     ` [PATCH v3 08/36] built-ins: consistently add "\n" between "usage" and options Ævar Arnfjörð Bjarmason
2022-09-30 21:31       ` Junio C Hamano
2022-09-30 18:07     ` [PATCH v3 09/36] doc SYNOPSIS & -h: word-wrap Ævar Arnfjörð Bjarmason
2022-09-30 18:07     ` [PATCH v3 10/36] doc txt & -h consistency: word-wrap Ævar Arnfjörð Bjarmason
2022-09-30 18:07     ` [PATCH v3 11/36] doc txt & -h consistency: fix incorrect alternates syntax Ævar Arnfjörð Bjarmason
2022-10-01  1:09       ` Junio C Hamano
2022-09-30 18:07     ` [PATCH v3 12/36] doc txt & -h consistency: add "-z" to cat-file "-h" Ævar Arnfjörð Bjarmason
2022-09-30 18:07     ` [PATCH v3 13/36] doc txt & -h consistency: balance unbalanced "[" and "]" Ævar Arnfjörð Bjarmason
2022-09-30 18:07     ` [PATCH v3 14/36] doc txt & -h consistency: correct padding around "[]()" Ævar Arnfjörð Bjarmason
2022-09-30 21:40       ` Junio C Hamano
2022-09-30 18:07     ` [PATCH v3 15/36] stash doc SYNOPSIS & -h: " Ævar Arnfjörð Bjarmason
2022-09-30 18:07     ` [PATCH v3 16/36] doc txt & -h consistency: use "<options>", not "<options>..." Ævar Arnfjörð Bjarmason
2022-09-30 21:43       ` Junio C Hamano
2022-09-30 18:07     ` [PATCH v3 17/36] t/helper/test-proc-receive.c: " Ævar Arnfjörð Bjarmason
2022-09-30 21:46       ` Junio C Hamano
2022-09-30 18:07     ` [PATCH v3 18/36] doc txt & -h consistency: fix mismatching labels Ævar Arnfjörð Bjarmason
2022-09-30 22:04       ` Junio C Hamano
2022-09-30 18:07     ` [PATCH v3 19/36] doc txt & -h consistency: add or fix optional "--" syntax Ævar Arnfjörð Bjarmason
2022-09-30 22:09       ` Junio C Hamano
2022-09-30 18:07     ` [PATCH v3 20/36] doc txt & -h consistency: make output order consistent Ævar Arnfjörð Bjarmason
2022-09-30 18:07     ` [PATCH v3 21/36] doc txt & -h consistency: add missing options and labels Ævar Arnfjörð Bjarmason
2022-10-01 18:43       ` Junio C Hamano
2022-10-01 23:44         ` Junio C Hamano
2022-10-02  4:52           ` Junio C Hamano
2022-10-04 10:13         ` Ævar Arnfjörð Bjarmason
2022-09-30 18:07     ` [PATCH v3 22/36] doc txt & -h consistency: make "rerere" consistent Ævar Arnfjörð Bjarmason
2022-10-01 18:45       ` Junio C Hamano
2022-10-03  9:00         ` Ævar Arnfjörð Bjarmason
2022-10-03 15:55           ` Junio C Hamano
2022-10-04  7:50             ` Ævar Arnfjörð Bjarmason
2022-10-05 17:20               ` Junio C Hamano
2022-09-30 18:07     ` [PATCH v3 23/36] doc txt & -h consistency: make "read-tree" consistent Ævar Arnfjörð Bjarmason
2022-10-01 18:48       ` Junio C Hamano
2022-09-30 18:07     ` [PATCH v3 24/36] doc txt & -h consistency: make "bundle" consistent Ævar Arnfjörð Bjarmason
2022-10-01 18:51       ` Junio C Hamano
2022-09-30 18:07     ` [PATCH v3 25/36] doc txt & -h consistency: use "git foo" form, not "git-foo" Ævar Arnfjörð Bjarmason
2022-10-01 18:59       ` Junio C Hamano
2022-09-30 18:07     ` [PATCH v3 26/36] doc txt & -h consistency: add missing options Ævar Arnfjörð Bjarmason
2022-09-30 18:07     ` [PATCH v3 27/36] doc txt & -h consistency: make "stash" consistent Ævar Arnfjörð Bjarmason
2022-09-30 18:07     ` [PATCH v3 28/36] doc txt & -h consistency: make "annotate" consistent Ævar Arnfjörð Bjarmason
2022-09-30 18:07     ` [PATCH v3 29/36] doc txt & -h consistency: use "[<label>...]" for "zero or more" Ævar Arnfjörð Bjarmason
2022-09-30 18:07     ` [PATCH v3 30/36] doc txt & -h consistency: make "diff-tree" consistent Ævar Arnfjörð Bjarmason
2022-09-30 18:07     ` [PATCH v3 31/36] doc txt & -h consistency: make "commit" consistent Ævar Arnfjörð Bjarmason
2022-09-30 18:07     ` [PATCH v3 32/36] reflog doc: list real subcommands up-front Ævar Arnfjörð Bjarmason
2022-09-30 18:07     ` [PATCH v3 33/36] worktree: define subcommand -h in terms of command -h Ævar Arnfjörð Bjarmason
2022-09-30 18:07     ` [PATCH v3 34/36] doc txt & -h consistency: make "worktree" consistent Ævar Arnfjörð Bjarmason
2022-09-30 18:07     ` [PATCH v3 35/36] tests: start asserting that *.txt SYNOPSIS matches -h output Ævar Arnfjörð Bjarmason
2022-10-02  1:25       ` Eric Sunshine
2022-09-30 18:07     ` [PATCH v3 36/36] tests: assert consistent whitespace in " Ævar Arnfjörð Bjarmason
2022-10-02  1:29       ` Eric Sunshine
2022-10-04 13:20     ` [PATCH v3 00/34] doc/UX: make txt & -h output more consistent Ævar Arnfjörð Bjarmason
2022-10-04 13:20       ` [PATCH v3 01/34] tests: assert *.txt SYNOPSIS and -h output Ævar Arnfjörð Bjarmason
2022-10-04 13:20       ` [PATCH v3 02/34] CodingGuidelines: update and clarify command-line conventions Ævar Arnfjörð Bjarmason
2022-10-04 13:20       ` [PATCH v3 03/34] builtin/bundle.c: indent with tabs Ævar Arnfjörð Bjarmason
2022-10-13 15:38       ` [PATCH v5 00/34] doc/UX: make txt & -h output more consistent Ævar Arnfjörð Bjarmason
2022-10-13 15:38         ` [PATCH v5 01/34] tests: assert *.txt SYNOPSIS and -h output Ævar Arnfjörð Bjarmason
2022-10-13 15:38         ` [PATCH v5 02/34] CodingGuidelines: update and clarify command-line conventions Ævar Arnfjörð Bjarmason
2022-10-13 15:38         ` [PATCH v5 03/34] builtin/bundle.c: indent with tabs Ævar Arnfjörð Bjarmason
2022-10-13 15:38         ` [PATCH v5 04/34] bundle: define subcommand -h in terms of command -h Ævar Arnfjörð Bjarmason
2022-10-13 15:38         ` [PATCH v5 05/34] doc SYNOPSIS: don't use ' for subcommands Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 06/34] doc SYNOPSIS: consistently use ' for commands Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 07/34] built-ins: consistently add "\n" between "usage" and options Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 08/34] doc txt & -h consistency: word-wrap Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 09/34] doc txt & -h consistency: fix incorrect alternates syntax Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 10/34] doc txt & -h consistency: add "-z" to cat-file "-h" Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 11/34] doc txt & -h consistency: balance unbalanced "[" and "]" Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 12/34] doc txt & -h consistency: correct padding around "[]()" Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 13/34] stash doc SYNOPSIS & -h: " Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 14/34] doc txt & -h consistency: use "<options>", not "<options>..." Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 15/34] doc SYNOPSIS & -h: use "-" to separate words in labels, not "_" Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 16/34] doc txt & -h consistency: fix mismatching labels Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 17/34] doc txt & -h consistency: add or fix optional "--" syntax Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 18/34] doc txt & -h consistency: make output order consistent Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 19/34] doc txt & -h consistency: add missing options and labels Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 20/34] doc txt & -h consistency: make "rerere" consistent Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 21/34] doc txt & -h consistency: make "read-tree" consistent Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 22/34] doc txt & -h consistency: make "bundle" consistent Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 23/34] doc txt & -h consistency: use "git foo" form, not "git-foo" Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 24/34] doc txt & -h consistency: add missing options Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 25/34] doc txt & -h consistency: make "stash" consistent Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 26/34] doc txt & -h consistency: make "annotate" consistent Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 27/34] doc txt & -h consistency: use "[<label>...]" for "zero or more" Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 28/34] doc txt & -h consistency: make "diff-tree" consistent Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 29/34] doc txt & -h consistency: make "commit" consistent Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 30/34] reflog doc: list real subcommands up-front Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 31/34] worktree: define subcommand -h in terms of command -h Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 32/34] doc txt & -h consistency: make "worktree" consistent Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 33/34] tests: start asserting that *.txt SYNOPSIS matches -h output Ævar Arnfjörð Bjarmason
2022-10-13 15:39         ` [PATCH v5 34/34] tests: assert consistent whitespace in " Ævar Arnfjörð Bjarmason
2022-10-13 16:33         ` [PATCH v5 00/34] doc/UX: make txt & -h output more consistent Junio C Hamano
2022-10-04 13:23     ` [PATCH v4 " Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 01/34] tests: assert *.txt SYNOPSIS and -h output Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 02/34] CodingGuidelines: update and clarify command-line conventions Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 03/34] builtin/bundle.c: indent with tabs Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 04/34] bundle: define subcommand -h in terms of command -h Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 05/34] doc SYNOPSIS: don't use ' for subcommands Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 06/34] doc SYNOPSIS: consistently use ' for commands Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 07/34] built-ins: consistently add "\n" between "usage" and options Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 08/34] doc txt & -h consistency: word-wrap Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 09/34] doc txt & -h consistency: fix incorrect alternates syntax Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 10/34] doc txt & -h consistency: add "-z" to cat-file "-h" Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 11/34] doc txt & -h consistency: balance unbalanced "[" and "]" Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 12/34] doc txt & -h consistency: correct padding around "[]()" Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 13/34] stash doc SYNOPSIS & -h: " Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 14/34] doc txt & -h consistency: use "<options>", not "<options>..." Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 15/34] doc SYNOPSIS & -h: use "-" to separate words in labels, not "_" Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 16/34] doc txt & -h consistency: fix mismatching labels Ævar Arnfjörð Bjarmason
2022-10-04 16:27         ` Junio C Hamano
2022-10-04 13:23       ` [PATCH v4 17/34] doc txt & -h consistency: add or fix optional "--" syntax Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 18/34] doc txt & -h consistency: make output order consistent Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 19/34] doc txt & -h consistency: add missing options and labels Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 20/34] doc txt & -h consistency: make "rerere" consistent Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 21/34] doc txt & -h consistency: make "read-tree" consistent Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 22/34] doc txt & -h consistency: make "bundle" consistent Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 23/34] doc txt & -h consistency: use "git foo" form, not "git-foo" Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 24/34] doc txt & -h consistency: add missing options Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 25/34] doc txt & -h consistency: make "stash" consistent Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 26/34] doc txt & -h consistency: make "annotate" consistent Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 27/34] doc txt & -h consistency: use "[<label>...]" for "zero or more" Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 28/34] doc txt & -h consistency: make "diff-tree" consistent Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 29/34] doc txt & -h consistency: make "commit" consistent Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 30/34] reflog doc: list real subcommands up-front Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 31/34] worktree: define subcommand -h in terms of command -h Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 32/34] doc txt & -h consistency: make "worktree" consistent Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 33/34] tests: start asserting that *.txt SYNOPSIS matches -h output Ævar Arnfjörð Bjarmason
2022-10-04 13:23       ` [PATCH v4 34/34] tests: assert consistent whitespace in " Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv8p4a871.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=emilyshaffer@google.com \
    --cc=git@vger.kernel.org \
    --cc=johncai86@gmail.com \
    --cc=jrnieder@gmail.com \
    --cc=me@ttaylorr.com \
    --cc=sunshine@sunshineco.com \
    --cc=vdye@github.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).