mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: Thierry Reding <>
Cc:, Taylor Blau <>
Subject: Re: [PATCH v2] am: Allow passing --no-verify flag
Date: Sun, 27 Nov 2022 10:27:30 +0900	[thread overview]
Message-ID: <xmqqv8n19ofx.fsf@gitster.g> (raw)
In-Reply-To: <Y4D+UU6l3YN9r9Xn@orome> (Thierry Reding's message of "Fri, 25 Nov 2022 18:41:37 +0100")

Thierry Reding <> writes:

> Thinking a bit more about this, if we let applypatch-msg run but ignore
> failures and continue on to commit the result, wouldn't that potentially
> allow committing garbage? I'm thinking about cases where applypatch-msg
> may attempt to normalize the message and fails badly, leaving a partial
> commit message or none at all.

That is a very reasonable way to think about this.  So I am sold on
your approach of not running the hook at all.


      reply	other threads:[~2022-11-27  1:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-19  0:50 [PATCH v2] am: Allow passing --no-verify flag Thierry Reding
2022-11-21  5:33 ` Junio C Hamano
2022-11-25 17:41   ` Thierry Reding
2022-11-27  1:27     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv8n19ofx.fsf@gitster.g \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).