From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Taylor Blau <me@ttaylorr.com>, git@vger.kernel.org
Subject: Re: [PATCH] git-compat-util.h: introduce CALLOC(x)
Date: Tue, 06 Dec 2022 10:35:54 +0900 [thread overview]
Message-ID: <xmqqv8mpnwjp.fsf@gitster.g> (raw)
In-Reply-To: <Y46ZJUsyp8UW5rFW@coredump.intra.peff.net> (Jeff King's message of "Mon, 5 Dec 2022 20:21:41 -0500")
Jeff King <peff@peff.net> writes:
> So you can think of "allocate this one element and zero it" as "calloc,
> but don't multiply" or as "malloc, but zero". Naming it CALLOC() is
> thinking of it as the former. If we think of it as the latter it could
> perhaps be MALLOCZ() or something. I don't know if that name is too
> subtle or not. We have xmemdupz(), which is basically the same thing;
> it's only a zero-terminator, but that is because we are writing non-zero
> bytes in the rest of it. Mostly I'd worry that it is easy to glance past
> the "Z".
I think the name for the former would be CALLOC_ONE(), as I would
rephrase it as "calloc, but just one element". I agree MALLOCZ()
would be fine for the other interpretation, and I do not have much
problem as much problem with the name as calling it CALLOC().
Thanks.
next prev parent reply other threads:[~2022-12-06 1:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 18:54 [PATCH] git-compat-util.h: introduce CALLOC(x) Taylor Blau
2022-12-05 21:01 ` René Scharfe
2022-12-05 22:36 ` Taylor Blau
2022-12-05 23:12 ` Ævar Arnfjörð Bjarmason
2022-12-06 1:47 ` Jeff King
2022-12-06 1:58 ` Ævar Arnfjörð Bjarmason
2022-12-07 6:02 ` Jeff King
2022-12-07 2:36 ` Taylor Blau
2022-12-07 2:34 ` Taylor Blau
2022-12-07 3:17 ` Ævar Arnfjörð Bjarmason
2022-12-06 1:43 ` Jeff King
2022-12-07 2:29 ` Taylor Blau
2022-12-07 3:51 ` Ævar Arnfjörð Bjarmason
2022-12-05 23:57 ` Junio C Hamano
2022-12-06 0:29 ` Taylor Blau
2022-12-06 1:21 ` Jeff King
2022-12-06 1:35 ` Junio C Hamano [this message]
2022-12-07 2:38 ` Taylor Blau
2022-12-07 6:08 ` Jeff King
2022-12-06 2:12 ` Ævar Arnfjörð Bjarmason
2022-12-07 6:06 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv8mpnwjp.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).