git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Wong <e@80x24.org>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] format-patch: add --mboxrd alias for --pretty=mboxrd
Date: Sun, 18 Dec 2022 13:24:56 +0900	[thread overview]
Message-ID: <xmqqv8m9wd7r.fsf@gitster.g> (raw)
In-Reply-To: <20221114205909.GA14736@dcvr> (Eric Wong's message of "Mon, 14 Nov 2022 20:59:09 +0000")

Eric Wong <e@80x24.org> writes:

> As I noted in the commit message, I think discussing --pretty=*
> in the context of format-patch would be confusing for users.

Sensible.

>> > +	if (mboxrd)
>> > +		rev.commit_format = CMIT_FMT_MBOXRD;
>> > +
>
> It could be something like this:
>
> 	if (rev.commit_format == CMIT_FMT_MBOXRD && !use_stdout)
> 		warning("mboxrd without --stdout makes no sense\n");
>
> But I'm on the fence about the warning.

Does it really hurt when generating individual files, or does it
naturally degenerate to the same as the plain old mbox, or
something?  If it does not hurt, then let's not clutter the output
with a message that may make the user worried unnecessarily.

Having said all that, if --pretty=mboxrd is usable, do we really
need the --mboxrd short-hand?  If we plan to eventually switch the
default output format to mboxrd (which I am assuming your longer
term vision), wouldn't it be the traditional format that may need a
short-hand when something goes wrong?

This change does not seem to be something we cannot live without,
and as a step in the direction to move all of us to mboxrd, this
feels somewhat a roundabout step.  I wonder if it would be more
direct to

 - declare that we will eventually switch to use mboxrd by default;

 - give a configuration knob to retain the current email as default;

 - do the usual deprecation dance.

After all, between email and mboxrd, the e-mailed patch format is
not something we choose per-invocation basis, is it?

Picking a suitable format per project and setting it in .git/config,
or picking a suitble format for yourself and setting it in
~/.gitconfig, and not having to think about it afterwards may be a
better use of our users' time.

Thanks.


  reply	other threads:[~2022-12-18  4:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-14  9:41 [PATCH] format-patch: add --mboxrd alias for --pretty=mboxrd Eric Wong
2022-11-14 16:53 ` Ævar Arnfjörð Bjarmason
2022-11-14 20:59   ` Eric Wong
2022-12-18  4:24     ` Junio C Hamano [this message]
2022-12-22 20:16       ` [PATCH v2] format-patch: support format.mboxrd with --stdout Eric Wong
2022-12-23  1:34         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqv8m9wd7r.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=e@80x24.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).