From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Max Gautier <max.gautier@redhat.com>
Subject: Re: [PATCH 0/2] gpg-interface: cleanup + convert low hanging fruit to configset API
Date: Fri, 10 Feb 2023 11:02:06 -0800 [thread overview]
Message-ID: <xmqqv8k9ibtd.fsf@gitster.g> (raw)
In-Reply-To: <230210.86mt5lx0bq.gmgdl@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Fri, 10 Feb 2023 11:29:31 +0100")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>> What's your intention of sending these?
>
> For them to be picked up on top of your jc/gpg-lazy-init.
>
>> I think we are already in
>> agreement that the churn may not be worth the risk, so if these are
>> "and here is the churn would look like, not for application", I
>> would understand it and appreciate it. But did you mean that these
>> patches are for application? I am not sure...
>
> I understood your "I specifically did not want anybody to start doing
> this line of analysis" in [1] to mean that you didn't want to have the
> sort of change that the last paragraph of 2/2 notes that we're
> deliberately not doing.
I didn't want to see "oh you are calling lazy_init here but you can
delay it even further" kind of comments that is wrong and wastes our
time.
> I.e. that we'd like to keep the gpg_interface_lazy_init() boilerplate,
> even though we might carefully reason that a specific API entry point
> won't need to initialize the file-scoped config variables right now.
It is the complete opposite of what I meant.
Changing
git_am_config(...) {
return git_default_config(...);
}
...
git_config(git_am_config);
to
/* no git_am_config() */
...
git_config(git_default_config);
is perfectly fine as a clean-up post series.
If we are moving away from git_config() callback style, and move to
git_config_get_*() style, the upthread already said it does not have
a good risk/benefit ratio, but if we were to do so, then we should
not leave some still using the callback style while others using
git_config_get_*(), which will lead to configuration read in a wrong
order and easily breaking precedence rules.
And if we were to move away completely from the callback style, then
I do not see a point to build such a series on top of the lazy init
patch, which is about staying with the callback style.
So, that is exactly why I asked the question after seeing it was
marked to apply on top of the lazy init thing, which did not make
sense to me.
prev parent reply other threads:[~2023-02-10 19:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <+TqEM21o+3TGx6D@coredump.intra.peff.net>
2023-02-09 14:35 ` [PATCH 0/2] gpg-interface: cleanup + convert low hanging fruit to configset API Ævar Arnfjörð Bjarmason
2023-02-09 14:35 ` [PATCH 1/2] {am,commit-tree,verify-{commit,tag}}: refactor away config wrapper Ævar Arnfjörð Bjarmason
2023-02-09 14:35 ` [PATCH 2/2] gpg-interface.c: lazily get GPG config variables on demand Ævar Arnfjörð Bjarmason
2023-02-09 21:27 ` [PATCH 0/2] gpg-interface: cleanup + convert low hanging fruit to configset API Junio C Hamano
2023-02-10 10:29 ` Ævar Arnfjörð Bjarmason
2023-02-10 19:02 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv8k9ibtd.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=max.gautier@redhat.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).