From: Junio C Hamano <gitster@pobox.com>
To: Clement Mabileau <mabileau.clement@gmail.com>
Cc: ctmbl via GitGitGadget <gitgitgadget@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] Fix mem leak in branch.c due to not-free newly added virtual_name variable
Date: Wed, 22 Mar 2023 13:52:45 -0700 [thread overview]
Message-ID: <xmqqv8iscxuq.fsf@gitster.g> (raw)
In-Reply-To: <bd5207a0-9783-6a15-93da-0904ecd21341@gmail.com> (Clement Mabileau's message of "Wed, 22 Mar 2023 21:00:54 +0100")
Clement Mabileau <mabileau.clement@gmail.com> writes:
> I just did it!
Nice to hear.
> Thanks for the review.
Well, I didn't "review" anything, though. I just commented on 2/2
that will become moot in your updated version, and I didn't even
look at 1/2.
The change(s) as a whole need to be reviewed by somebody.
Thanks.
next prev parent reply other threads:[~2023-03-22 20:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 9:42 [PATCH 0/2] branch: improve error log on branch not found by checking remotes refs ClementMabileau via GitGitGadget
2023-03-22 9:42 ` [PATCH 1/2] " ctmbl via GitGitGadget
2023-03-22 9:42 ` [PATCH 2/2] Fix mem leak in branch.c due to not-free newly added virtual_name variable ctmbl via GitGitGadget
2023-03-22 16:52 ` Junio C Hamano
2023-03-22 20:00 ` Clement Mabileau
2023-03-22 20:52 ` Junio C Hamano [this message]
2023-03-22 20:03 ` [PATCH v2] branch: improve error log on branch not found by checking remotes refs ClementMabileau via GitGitGadget
2023-03-22 22:25 ` Junio C Hamano
2023-03-23 15:51 ` Clement Mabileau
2023-04-04 13:30 ` Clement Mabileau
2023-04-04 16:24 ` Junio C Hamano
2023-04-05 9:15 ` Clement Mabileau
2023-04-05 11:43 ` [PATCH v3] " ClementMabileau via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqv8iscxuq.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=mabileau.clement@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).