From: Junio C Hamano <gitster@pobox.com>
To: William Clifford <mr.william.clifford@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC 0/2] custom format for interactive rebase todo
Date: Tue, 09 Sep 2014 09:58:13 -0700 [thread overview]
Message-ID: <xmqqtx4gloii.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <864mwhi9qu.fsf@gmail.com> (William Clifford's message of "Mon, 8 Sep 2014 21:47:56 -0700")
William Clifford <mr.william.clifford@gmail.com> writes:
> A couple of examples:
>
> - `git config sequence.format "%<(12,trunc)%ae %s"`
> - `git config sequence.format "%s <%aN %aE>"`
> - `git config sequence.format "%s%n%%n%b"`
> ... I'm unsure what would happen if I tried to rebase with the
> third style unedited or uncommented.
It should be simply forbidden. The body part may have a line that
is similar enough (i.e. starting with one of the command words and
then a hexadecimal string) to confuse the sequencing machinery.
Other than that safety issue, I am not fundamentally opposed to the
idea.
As to the implementation in 1/2, your unconditional use of ">%h" is
wrong (you would end up including the commits from the left side).
Use '%m' instead of a hardcoded '>', perhaps?
next prev parent reply other threads:[~2014-09-09 16:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 4:47 [PATCH/RFC 0/2] custom format for interactive rebase todo William Clifford
2014-09-09 16:58 ` Junio C Hamano [this message]
2014-09-09 17:07 ` Junio C Hamano
2014-09-10 14:48 ` William Clifford
2014-09-10 17:11 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtx4gloii.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mr.william.clifford@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).