* [PATCH] git-completion.tcsh: fix redirect with noclobber
@ 2015-06-09 17:25 Ariel Faigon
2015-06-09 18:20 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Ariel Faigon @ 2015-06-09 17:25 UTC (permalink / raw
To: git
tcsh users who happen to have 'set noclobber' elsewhere in their
~/.tcshrc or ~/.cshrc startup files get a 'File exist' error, and
the tcsh completion file doesn't get generated/updated.
Adding a `!` in the redirect works correctly for both clobber (default)
and 'set noclobber' users.
Helped-by: Junio C Hamano <gitster@pobox.com>
Reviewed-by: Christian Couder <christian.couder@gmail.com>
Signed-off-by: Ariel Faigon <github.2009@yendor.com>
---
contrib/completion/git-completion.tcsh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/completion/git-completion.tcsh b/contrib/completion/git-completion.tcsh
index 6104a42..4a790d8 100644
--- a/contrib/completion/git-completion.tcsh
+++ b/contrib/completion/git-completion.tcsh
@@ -41,7 +41,7 @@ if ( ! -e ${__git_tcsh_completion_original_script} ) then
exit
endif
-cat << EOF > ${__git_tcsh_completion_script}
+cat << EOF >! ${__git_tcsh_completion_script}
#!bash
#
# This script is GENERATED and will be overwritten automatically.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] git-completion.tcsh: fix redirect with noclobber
2015-06-09 17:25 [PATCH] git-completion.tcsh: fix redirect with noclobber Ariel Faigon
@ 2015-06-09 18:20 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2015-06-09 18:20 UTC (permalink / raw
To: Ariel Faigon; +Cc: git
Ariel Faigon <github.2009@yendor.com> writes:
> tcsh users who happen to have 'set noclobber' elsewhere in their
> ~/.tcshrc or ~/.cshrc startup files get a 'File exist' error, and
> the tcsh completion file doesn't get generated/updated.
>
> Adding a `!` in the redirect works correctly for both clobber (default)
> and 'set noclobber' users.
>
> Helped-by: Junio C Hamano <gitster@pobox.com>
> Reviewed-by: Christian Couder <christian.couder@gmail.com>
> Signed-off-by: Ariel Faigon <github.2009@yendor.com>
> ---
Thanks for enduring three iterations for a single-liner. This
versio will show nicely in "git log -p" output ;-)
In case anybody is wondering, that "Helped-by: notifications@github"
was merely because I said "this change makes sense, care to send it
over to us at git@vger?" from github UI on Ariel's commit. I do not
deserve helped-by for merely encouraging participation.
Will queue. Thanks again.
>
> contrib/completion/git-completion.tcsh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.tcsh b/contrib/completion/git-completion.tcsh
> index 6104a42..4a790d8 100644
> --- a/contrib/completion/git-completion.tcsh
> +++ b/contrib/completion/git-completion.tcsh
> @@ -41,7 +41,7 @@ if ( ! -e ${__git_tcsh_completion_original_script} ) then
> exit
> endif
>
> -cat << EOF > ${__git_tcsh_completion_script}
> +cat << EOF >! ${__git_tcsh_completion_script}
> #!bash
> #
> # This script is GENERATED and will be overwritten automatically.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-09 18:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-09 17:25 [PATCH] git-completion.tcsh: fix redirect with noclobber Ariel Faigon
2015-06-09 18:20 ` Junio C Hamano
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).