git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org, christian.couder@gmail.com,
	Matthieu.Moy@grenoble-inp.fr
Subject: Re: [PATCH v6 06/11] ref-filter: implement '--merged' and '--no-merged' options
Date: Mon, 29 Jun 2015 11:28:22 -0700	[thread overview]
Message-ID: <xmqqtwtq9xo9.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <xmqqegkubddy.fsf@gitster.dls.corp.google.com> (Junio C. Hamano's message of "Mon, 29 Jun 2015 11:03:37 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> +static void do_merge_filter(struct ref_filter_cbdata *ref_cbdata)
>> +{
>> ...
>> +	for (i = 0; i < array->nr; i++) {
>> +		struct ref_array_item *item = array->items[i];
>> +		add_pending_object(&revs, &item->commit->object, item->refname);
>> +		to_clear[i] = item->commit;
>> +	}
>> +
>> +	filter->merge_commit->object.flags |= UNINTERESTING;
>> +	add_pending_object(&revs, &filter->merge_commit->object, "");
>> +
>> +	revs.limited = 1;
>> +	if (prepare_revision_walk(&revs))
>> +		die(_("revision walk setup failed"));
>> + ...
>
> Did this come from somewhere else (e.g. tag -l or branch -l)?  If
> so, you'd need a note similar to what you added in [02/11] to the
> original.

Ah, now I see this came from a part of print_ref_list in
builtin/branch.c; you would want to leave a note there.

  reply	other threads:[~2015-06-29 18:28 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25  8:46 [PATCH v6 00/11] add options to for-each-ref Karthik Nayak
2015-06-25  8:57 ` [PATCH v6 01/11] t6302: for-each-ref tests for ref-filter APIs Karthik Nayak
2015-06-25  8:57   ` [PATCH v6 02/11] tag: libify parse_opt_points_at() Karthik Nayak
2015-06-25  8:57   ` [PATCH v6 03/11] ref-filter: implement '--points-at' option Karthik Nayak
2015-06-29 17:40     ` Junio C Hamano
2015-06-29 19:37       ` Karthik Nayak
2015-06-25  8:57   ` [PATCH v6 04/11] for-each-ref: add " Karthik Nayak
2015-06-29 17:46     ` Junio C Hamano
2015-06-29 19:55       ` Karthik Nayak
2015-06-29 18:38     ` Junio C Hamano
2015-06-29 19:11       ` Karthik Nayak
2015-06-25  8:57   ` [PATCH v6 05/11] ref-filter: add parse_opt_merge_filter() Karthik Nayak
2015-06-25  8:57   ` [PATCH v6 06/11] ref-filter: implement '--merged' and '--no-merged' options Karthik Nayak
2015-06-29 18:03     ` Junio C Hamano
2015-06-29 18:28       ` Junio C Hamano [this message]
2015-06-30 13:38       ` Karthik Nayak
2015-06-30 15:58         ` Junio C Hamano
2015-06-30 16:04           ` Karthik Nayak
2015-06-25  8:57   ` [PATCH v6 07/11] for-each-ref: add " Karthik Nayak
2015-06-25  8:57   ` [PATCH v6 08/11] parse-option: rename parse_opt_with_commit() Karthik Nayak
2015-06-25  8:57   ` [PATCH v6 09/11] parse-options.h: add macros for '--contains' option Karthik Nayak
2015-06-25  8:57   ` [PATCH v6 10/11] ref-filter: implement " Karthik Nayak
2015-06-25  8:57   ` [PATCH v6 11/11] for-each-ref: add " Karthik Nayak
2015-06-29 18:14   ` [PATCH v6 01/11] t6302: for-each-ref tests for ref-filter APIs Junio C Hamano
2015-06-29 18:43     ` Karthik Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqtwtq9xo9.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).