git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: huebbe <nathanael.huebbe@informatik.uni-hamburg.de>,
	stefan.naewe@atlas-elektronik.com, git@vger.kernel.org
Subject: Re: Bug: Incorrect stripping of the [PATCH] prefix in git-am
Date: Tue, 01 Dec 2015 18:24:10 -0800	[thread overview]
Message-ID: <xmqqtwo16111.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20151202005826.GE28197@sigill.intra.peff.net> (Jeff King's message of "Tue, 1 Dec 2015 19:58:27 -0500")

Jeff King <peff@peff.net> writes:

> The "[]" convention is a microformat used by Linux kernel folks. So it's
> not "whoops, we are stripping stuff not added by git". It is respecting
> a microformat used by the tool's authors.
>
> That being said, if we were choosing a default from scratch today, it
> might go the other way. But we aren't, and we have to deal with the
> burden of breaking existing scripts by flipping it.

And I do think it no longer is sensible to expect that it still is
kernel-only convention.  Any project that uses e-mail based workflow
with Git have known how "[]" microformat works, may even have taken
advantage of it to build their workflow around it, and flipping the
default will only hurt them.

A project that chooses not to follow the convention can easily tweak
a knob to keep using different conventions, so I do not see anything
to change here.

  parent reply	other threads:[~2015-12-02  2:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-25 15:29 Bug: Incorrect stripping of the [PATCH] prefix in git-am huebbe
2015-11-25 15:44 ` stefan.naewe
2015-11-25 15:59   ` huebbe
2015-12-02  0:58     ` Jeff King
2015-12-02  1:10       ` Stefan Beller
2015-12-02  2:27         ` Junio C Hamano
2015-12-02  2:24       ` Junio C Hamano [this message]
2015-12-02 12:38       ` huebbe
2015-12-02 15:49         ` Jeff King
2015-12-03 10:32           ` huebbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqtwo16111.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=nathanael.huebbe@informatik.uni-hamburg.de \
    --cc=peff@peff.net \
    --cc=stefan.naewe@atlas-elektronik.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).