From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: jrnieder@gmail.com, git@vger.kernel.org, Jens.Lehmann@web.de,
pclouds@gmail.com
Subject: Re: [PATCH 07/15] submodule deinit: loose requirement for giving '.'
Date: Fri, 29 Apr 2016 11:27:42 -0700 [thread overview]
Message-ID: <xmqqtwikxobl.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1461703833-10350-8-git-send-email-sbeller@google.com> (Stefan Beller's message of "Tue, 26 Apr 2016 13:50:25 -0700")
Stefan Beller <sbeller@google.com> writes:
> This is needed later to make a distinction between 'all specified'
> and the default group of submodules.
s/loose/lose/;
Again, this can be separated as an independent preliminary clean-up.
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
> git-submodule.sh | 5 -----
> t/t7400-submodule-basic.sh | 1 -
> 2 files changed, 6 deletions(-)
>
> diff --git a/git-submodule.sh b/git-submodule.sh
> index d7a5e1a..253ad07 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -440,11 +440,6 @@ cmd_deinit()
> shift
> done
>
> - if test $# = 0
> - then
> - die "$(eval_gettext "Use '.' if you really want to deinitialize all submodules")"
> - fi
> -
> git submodule--helper list --prefix "$wt_prefix" "$@" |
> while read mode sha1 stage sm_path
> do
> diff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh
> index e9d1d58..ac477b2 100755
> --- a/t/t7400-submodule-basic.sh
> +++ b/t/t7400-submodule-basic.sh
> @@ -932,7 +932,6 @@ test_expect_success 'submodule deinit . deinits all initialized submodules' '
> git submodule update --init &&
> git config submodule.example.foo bar &&
> git config submodule.example2.frotz nitfol &&
> - test_must_fail git submodule deinit &&
> git submodule deinit . >actual &&
> test -z "$(git config --get-regexp "submodule\.example\.")" &&
> test -z "$(git config --get-regexp "submodule\.example2\.")" &&
next prev parent reply other threads:[~2016-04-29 18:27 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 20:50 [PATCH 00/15] submodule groups (once again) Stefan Beller
2016-04-26 20:50 ` [PATCH 01/15] string_list: add string_list_duplicate Stefan Beller
2016-04-26 22:37 ` Junio C Hamano
2016-04-27 18:02 ` Stefan Beller
2016-04-27 21:11 ` Junio C Hamano
2016-04-27 21:17 ` Stefan Beller
2016-04-27 23:17 ` Junio C Hamano
2016-04-27 23:24 ` Stefan Beller
2016-04-26 20:50 ` [PATCH 02/15] submodule doc: write down what we want to achieve in this series Stefan Beller
2016-04-26 22:42 ` Junio C Hamano
2016-04-26 20:50 ` [PATCH 03/15] submodule add: label submodules if asked to Stefan Beller
2016-04-26 22:49 ` Junio C Hamano
2016-04-26 22:50 ` Jacob Keller
2016-04-26 23:19 ` Stefan Beller
2016-04-27 3:24 ` Jacob Keller
2016-04-26 20:50 ` [PATCH 04/15] submodule-config: keep labels around Stefan Beller
2016-04-26 20:50 ` [PATCH 05/15] submodule-config: check if submodule a submodule is in a group Stefan Beller
2016-04-26 22:58 ` Junio C Hamano
2016-04-26 23:17 ` Junio C Hamano
2016-04-27 23:00 ` Stefan Beller
2016-04-26 20:50 ` [PATCH 06/15] submodule init: redirect stdout to stderr Stefan Beller
2016-04-29 18:27 ` Junio C Hamano
2016-04-29 18:38 ` Stefan Beller
2016-04-26 20:50 ` [PATCH 07/15] submodule deinit: loose requirement for giving '.' Stefan Beller
2016-04-29 18:27 ` Junio C Hamano [this message]
2016-04-26 20:50 ` [PATCH 08/15] submodule--helper list: respect submodule groups Stefan Beller
2016-04-29 18:31 ` Junio C Hamano
2016-04-26 20:50 ` [PATCH 09/15] submodule--helper init: " Stefan Beller
2016-04-26 20:50 ` [PATCH 10/15] submodule--helper update_clone: " Stefan Beller
2016-04-26 20:50 ` [PATCH 11/15] diff: ignore submodules excluded by groups Stefan Beller
2016-04-29 18:37 ` Junio C Hamano
2016-04-29 19:17 ` Stefan Beller
2016-05-05 19:57 ` Stefan Beller
2016-05-05 20:19 ` Junio C Hamano
2016-05-05 21:02 ` Stefan Beller
2016-05-05 22:20 ` Junio C Hamano
2016-05-05 22:50 ` Stefan Beller
2016-05-05 23:07 ` Junio C Hamano
2016-05-06 6:08 ` Junio C Hamano
2016-05-06 18:23 ` Stefan Beller
2016-05-06 18:59 ` Junio C Hamano
2016-04-26 20:50 ` [PATCH 12/15] git submodule summary respects groups Stefan Beller
2016-04-29 18:38 ` Junio C Hamano
2016-04-26 20:50 ` [PATCH 13/15] cmd_status: respect submodule groups Stefan Beller
2016-04-26 20:50 ` [PATCH 14/15] cmd_diff: " Stefan Beller
2016-04-26 20:50 ` [PATCH 15/15] clone: allow specification of submodules to be cloned Stefan Beller
2016-04-26 22:19 ` [PATCH 00/15] submodule groups (once again) Junio C Hamano
2016-04-26 22:26 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtwikxobl.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).