git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Philip Oakley" <philipoakley@iee.org>
Cc: "Git List" <git@vger.kernel.org>, "Duy" <pclouds@gmail.com>
Subject: Re: /* compiler workaround */ - what was the issue?
Date: Thu, 05 May 2016 14:41:43 -0700	[thread overview]
Message-ID: <xmqqtwic9o88.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <17E04501C9474282B87758C7998A1F5B@PhilipOakley> (Philip Oakley's message of "Thu, 5 May 2016 21:48:40 +0100")

"Philip Oakley" <philipoakley@iee.org> writes:

>     int saved_namelen = saved_namelen; /* compiler workaround */
>
> Which then becomes an MSVC compile warning C4700: uninitialized local 
> variable.
>
> I'm wondering what was the compiler workaround being referred to? i.e. why 
> does it need that tweak? There's no mention of the reason in the commit 
> message.

That was a fairly well-known workaround for GCC that issues a false
warning that variable is used before initialized.  I thought we
stopped using it several years ago in new code after doing a bulk
sanitizing (I think the new recommended workaround was to initialise
such a variable to the nil value like '0' for integers).

  reply	other threads:[~2016-05-05 21:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AA5B2B1715BAF7438221293187A417A7BDE9D11D@desmdswms002.des.grplnk.net>
2016-05-05 20:48 ` /* compiler workaround */ - what was the issue? Philip Oakley
2016-05-05 21:41   ` Junio C Hamano [this message]
2016-05-06 10:17     ` Duy Nguyen
2016-05-06 13:15       ` Philip Oakley
2016-05-06 18:05         ` Ramsay Jones
2016-05-06 18:33           ` Philip Oakley
2016-05-06 18:54           ` Junio C Hamano
2016-05-06 19:30             ` Marc Branchaud
2016-05-06 19:57               ` Junio C Hamano
2016-05-06 20:01                 ` Stefan Beller
2016-05-09 19:40                   ` Philip Oakley
2016-05-09 19:49                     ` Randall S. Becker
2016-05-06 20:28                 ` Marc Branchaud
2016-05-06 20:21             ` Ramsay Jones
2016-05-06 21:17               ` Ramsay Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqtwic9o88.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    --cc=philipoakley@iee.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).