From: Junio C Hamano <gitster@pobox.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org, jacob.keller@gmail.com, ramsay@ramsayjones.plus.com
Subject: Re: [PATCH v9 11/20] ref-filter: introduce refname_atom_parser()
Date: Tue, 27 Dec 2016 13:04:49 -0800 [thread overview]
Message-ID: <xmqqtw9p6phx.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: 20161227162357.28212-12-Karthik.188@gmail.com
Karthik Nayak <karthik.188@gmail.com> writes:
> +symref::
> + The ref which the given symbolic ref refers to. If not a
> + symbolic ref, nothing is printed. Respects the `:short` and
> + `:strip` options in the same way as `refname` above.
> +
I am slightly unhappy with this name. If we had an atom that lets
you ask "Is this a symref?" and yields "" or "->", it could also be
called symref, and we would name it "is_symref" or something to
disambiguate it. Then it is only fair to give this one that lets
you ask "What does this symref point at?" a bit more specific name,
like "symref_target" or something.
But probably I am worried too much. "is_symref", if necessary, can
be written as "%(if:notequals=)%(symref)%(then)...%(else)...%(end)"
and it is not likely that it would be used often, so let's keep it
as-is.
next prev parent reply other threads:[~2016-12-27 21:18 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 16:23 [PATCH v9 00/20] port branch.c to use ref-filter's printing options Karthik Nayak
2016-12-27 16:23 ` [PATCH v9 01/20] ref-filter: implement %(if), %(then), and %(else) atoms Karthik Nayak
2016-12-27 20:58 ` Junio C Hamano
2016-12-28 6:47 ` Karthik Nayak
2016-12-27 16:23 ` [PATCH v9 02/20] ref-filter: include reference to 'used_atom' within 'atom_value' Karthik Nayak
2016-12-27 20:59 ` Junio C Hamano
2016-12-28 7:45 ` Karthik Nayak
2016-12-27 16:23 ` [PATCH v9 03/20] ref-filter: implement %(if:equals=<string>) and %(if:notequals=<string>) Karthik Nayak
2016-12-27 21:00 ` Junio C Hamano
2016-12-28 7:45 ` Karthik Nayak
2016-12-27 16:23 ` [PATCH v9 04/20] ref-filter: modify "%(objectname:short)" to take length Karthik Nayak
2016-12-27 16:23 ` [PATCH v9 05/20] ref-filter: move get_head_description() from branch.c Karthik Nayak
2016-12-27 16:23 ` [PATCH v9 06/20] ref-filter: introduce format_ref_array_item() Karthik Nayak
2016-12-27 16:23 ` [PATCH v9 07/20] ref-filter: make %(upstream:track) prints "[gone]" for invalid upstreams Karthik Nayak
2016-12-27 16:23 ` [PATCH v9 08/20] ref-filter: add support for %(upstream:track,nobracket) Karthik Nayak
2016-12-27 16:23 ` [PATCH v9 09/20] ref-filter: make "%(symref)" atom work with the ':short' modifier Karthik Nayak
2016-12-27 16:23 ` [PATCH v9 10/20] ref-filter: introduce refname_atom_parser_internal() Karthik Nayak
2016-12-27 16:23 ` [PATCH v9 11/20] ref-filter: introduce refname_atom_parser() Karthik Nayak
2016-12-27 21:04 ` Junio C Hamano [this message]
2016-12-28 7:56 ` Karthik Nayak
2016-12-27 16:23 ` [PATCH v9 12/20] ref-filter: make remote_ref_atom_parser() use refname_atom_parser_internal() Karthik Nayak
2016-12-27 16:23 ` [PATCH v9 13/20] ref-filter: rename the 'strip' option to 'lstrip' Karthik Nayak
2016-12-27 16:23 ` [PATCH v9 14/20] ref-filter: Do not abruptly die when using the 'lstrip=<N>' option Karthik Nayak
2016-12-27 16:23 ` [PATCH v9 15/20] ref-filter: modify the 'lstrip=<N>' option to work with negative '<N>' Karthik Nayak
2016-12-27 21:11 ` Junio C Hamano
2016-12-28 3:08 ` Jacob Keller
2016-12-28 8:54 ` Karthik Nayak
2016-12-27 16:23 ` [PATCH v9 16/20] ref-filter: add an 'rstrip=<N>' option to atoms which deal with refnames Karthik Nayak
2016-12-27 16:23 ` [PATCH v9 17/20] ref-filter: allow porcelain to translate messages in the output Karthik Nayak
2016-12-27 16:23 ` [PATCH v9 18/20] branch, tag: use porcelain output Karthik Nayak
2016-12-27 16:23 ` [PATCH v9 19/20] branch: use ref-filter printing APIs Karthik Nayak
2016-12-27 21:17 ` Junio C Hamano
2016-12-28 9:40 ` Karthik Nayak
2016-12-27 16:23 ` [PATCH v9 20/20] branch: implement '--format' option Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtw9p6phx.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jacob.keller@gmail.com \
--cc=karthik.188@gmail.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).